Skip to content

Conversation

@aemonge
Copy link
Contributor

@aemonge aemonge commented Dec 17, 2024

No description provided.

@AckslD
Copy link
Owner

AckslD commented Dec 22, 2024

Hi @aemonge! Thanks for the PR, I'm planning to look into this in more detail soon. Would you in the meantime remove all the formatting changes which distracts from the actual changes. I should probably add a stylua.toml to this repo as I preper 2 spaces as indentation.

@aemonge
Copy link
Contributor Author

aemonge commented Jan 8, 2025

Is this better?

@AckslD
Copy link
Owner

AckslD commented Jan 11, 2025

Yes, thanks! Would you also mind adding quote_style = "AutoPreferSingle" to the stylua.toml? Or let me know if you prefer me to do it.

@aemonge
Copy link
Contributor Author

aemonge commented Jan 14, 2025

:) Done

@AckslD
Copy link
Owner

AckslD commented Feb 5, 2025

Btw, not sure why CI is failing, need to look into that, seems unrelated to this PR

@aemonge
Copy link
Contributor Author

aemonge commented Feb 5, 2025

Please let me know if it's related to the PR, and I'll work on it :)

It feels good to participate in the repo.

@AckslD
Copy link
Owner

AckslD commented Feb 9, 2025

If you rebase on main now the CI should work again. Please also fix the remaining Path join changes, see above.

@aemonge
Copy link
Contributor Author

aemonge commented Feb 11, 2025

Hey @AckslD there were too many conflicts for a rebase, I hope a merge is ok with you.

@aemonge
Copy link
Contributor Author

aemonge commented Mar 12, 2025

I've also added support for UV with .venv dirs, let me know it I should split the MR

@aemonge
Copy link
Contributor Author

aemonge commented Mar 17, 2025

Thanks for noticing this @neolooong

@aemonge
Copy link
Contributor Author

aemonge commented Apr 7, 2025

@AckslD Code was broken, now it should work 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants