Open
Conversation
.strm and .pls music (playlist) files could only be played on clicking/play on the file. Queueing was not possible because the .strm and .pls files would be processed as a directory resulting in the error: DEBUG: CGUIMediaWindow::GetDirectory (<path> test.strm) XFILE::CDirectory::GetDirectory - Error getting <path> test.strm To my knowledge and tests, the 'playlist and music_nav window' check are a redundant combination. These checks have been removed from the if statements.
This completes a TODO left in bd6697b.
… the detection process starts. Before the associated fix in peripheral.joystick, updates were only sent for updated axes. Now, peripheral.joystick sends events for every known axis on every frame. This means that we can reliably detect an initial position of the axis. There is one caveat - on OSX, axes are not reported until first *moved*. This means that until a trigger is pressed at least once, its position is unknown. This breaks button mapping, but the next attempt should work.
Fix queueing .strm and .pls music files
[PVR] Krypton: Fix trac17246 - another approach
Fix analog sticks backport
Backport: Remove generated file
[Backport] Remove AEDefines_override.h
[estuary] three minor fixes
[skins] show video indicator in slideshow window
AESinkAudioTrack: FIX Samplerates > 192 khz
Fix setting exact compiler when cross-compiling libdvd* Otherwise it can result in problems when configure decides to use one with different ABI == [..]/libdvdnav.a: member [..]/libdvdnav.a(dvdnav.o) in archive is not an object collect2: error: ld returned 1 exit status CMakeFiles/wrap_libdvdnav.dir/build.make:63: recipe for target 'system/players/VideoPlayer/libdvdnav-arm.so' failed ==
…e screen widget did not display 'resumable' bitmap anymore.
Improve performance for python addons using xbmcgui.ListItem
…hediconvar [estuary] Krypton: Fix regression in WallWatchedIconVar. Recent recordings hom…
…ut plane format conversion functionality
…callback interface and new variable processedSamples
…ssing buffer interface
AchimTuran
force-pushed
the
AudioDSP/V2/core_reimplementation
branch
from
ebace1c to
978bf6e
Compare
…d replace it with CAEResampleFactory
…an request for processing?)
AchimTuran
pushed a commit
that referenced
this pull request
Jun 17, 2017
Report from Android O tesing on O:
From: <android-developer-preview-no-reply@google.com>
Date: Apr 19, 2017 21:20
Subject: Native crash when trying to open Kodi addon
To: <developers@kodi.tv>
Cc: <androidsupport@kodi.tv>
Hello,
In preparation for the upcoming release of Android O, we've been
rigorously testing popular applications on Google Play, including ”Kodi"
[org.xbmc.kodi].
During testing, we uncovered a bug specific to your application running
on the Android O Developer Preview. Here are the details:
Step(s) to Reproduce:
Install “Kodi” application from Play store
Launch the application
Tap Add-Ons from the menu
Expected Result(s):
App should not crash when tapping Add-Ons
Observed Result(s):
App crashes when tapping Add-Ons
Possible Root Cause(s):
It looks like Kodi is fetching an icon from PackageManager and
calling this method: icon.getBitmap(). This used to work in N and below
because all Icons were png, in which they could be cast to
BitmapDrawable. However, starting in the next OS, there is no guarantee
icon drawable objects can automatically convert to BitmapDrawable.
There is also no guarantee that all of BitmapDrawable's methods (such as
getBitmap) will be readily available.
Log:
java_vm_ext.cc:504] JNI DETECTED ERROR IN APPLICATION: mid == null
Revision: '0'
ABI: 'arm64'
pid: 9423, tid: 9469, name: Thread-5 >>> org.xbmc.kodi <<<
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
Abort message: 'java_vm_ext.cc:504] JNI DETECTED ERROR IN APPLICATION:
mid == null'
x0 0000000000000000 x1 00000000000024fd x2 0000000000000006
x3 0000000000000008
x4 0000000000000114 x5 00000000000000ff x6 0000000000000000
x7 0080808080808080
x8 0000000000000083 x9 6cd9bf0d77661d2f x10 0000000000000001
x11 0000000000000001
x12 ffffffffffffffff x13 0000000000000008 x14 ffffffffffffffff
x15 0030fcf94d051582
x16 00000073abd6d300 x17 00000073abd0f3fc x18 0000000000000020
x19 00000000000024cf
x20 00000000000024fd x21 0000007388714700 x22 0000000000000002
x23 00000000000000c1
x24 00000000000009b7 x25 000000738c527600 x26 00000000000009b6
x27 00000073883fea20
x28 0000000000000059 x29 00000073883fe8c0 x30 00000073abcc390c
sp 00000073883fe880 pc 00000073abd0f404 pstate
0000000000000000
backtrace:
#00 pc 0000000000069404 /system/lib64/libc.so (tgkill+8)
#1 pc 000000000001d908 /system/lib64/libc.so (abort+80)
#2 pc 00000000004325bc /system/lib64/libart.so
(_ZN3art7Runtime5AbortEPKc+528)
#3 pc 0000000000432ccc /system/lib64/libart.so
(_ZN3art7Runtime7AborterEPKc+24)
#4 pc 000000000051c578 /system/lib64/libart.so
(_ZN7android4base10LogMessageD1Ev+1016)
#5 pc 00000000002d0920 /system/lib64/libart.so
(_ZN3art9JavaVMExt8JniAbortEPKcS2_+1716)
#6 pc 00000000002d0bec /system/lib64/libart.so
(_ZN3art9JavaVMExt9JniAbortFEPKcS2_z+176)
#7 pc 000000000031482c /system/lib64/libart.so
(_ZN3art3JNI17CallObjectMethodVEP7_JNIEnvP8_jobjectP10_jmethodIDSt9__va_list+1440)
#8 pc 00000000013b8920 /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so
(_ZN3jni7details20call_jhobject_methodEP7_JNIEnvP8_jobjectP10_jmethodIDz+148)
#9 pc 000000000139f7a4 /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so
(_ZN18CJNIBitmapDrawable9getBitmapEv+148)
#10 pc 000000000130b8ac /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so
(_ZN5XFILE15CFileAndroidApp8ReadIconEPPhPjS3_+1008)
#11 pc 0000000000cb33fc /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so
(_ZN12CBaseTexture12LoadFromFileERKSsjjbS1_+232)
#12 pc 0000000000e8d6b0 /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so (_ZN12CImageLoader6DoWorkEv+524)
#13 pc 0000000000ad8ab8 /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so (_ZN10CJobWorker7ProcessEv+68)
#14 pc 0000000000b69184 /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so (_ZN7CThread6ActionEv+44)
#15 pc 0000000000b69418 /data/app/org.xbmc.kodi-TYKIN-
5zBb80hcqOZMy_tw==/lib/arm64/libkodi.so
(_ZN7CThread12staticThreadEPv+148)
#16 pc 0000000000065db4 /system/lib64/libc.so
(_ZL15__pthread_startPv+36)
#17 pc 000000000001ec9c /system/lib64/libc.so (__start_thread+68)
We wanted to let you know so you could take a look and address the
issue.
Please do not reply to this message. If you discover an issue with the
platform running Android O Dev Preview, please file a bug in our issue
tracker.
Thanks!
Android Support Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AudioDSP V2 implementation based on the active object- and MVC-pattern.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: