Select From Search Field #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Minasyan1, A few items that I would start with before we can do a full review:
|
Wolfe1
reviewed
Sep 12, 2024
src/Zoomba/GUILibrary.py
Outdated
| def select_from_search_field(self, locator, text, timeout=None): | ||
| """This is a Selenium keyword that first attempts to find a web element, clears it, and then inputs text. | ||
| Subsequently, it selects the first item in the search dropdown. | ||
| If typing into the element fails, the keyword will scroll to the bottom of the page and try again. |
There was a problem hiding this comment.
Does it really do this? I don't get any indication from the code that this is the case.
Minasyan1
changed the title
Wolfe1
reviewed
Sep 19, 2024
src/Zoomba/GUILibrary.py
Outdated
| from selenium.webdriver.common.keys import Keys | ||
| from selenium.webdriver.support.ui import WebDriverWait | ||
| from selenium.webdriver.support import expected_conditions as EC | ||
| from selenium.webdriver.common.by import By |
There was a problem hiding this comment.
I don't think you need any of these anymore
Wolfe1
reviewed
Sep 19, 2024
test/GUI/test_gui.py
Outdated
| @@ -6,6 +6,7 @@ | |||
| from Zoomba.GUILibrary import GUILibrary | |||
| from Zoomba.Helpers import ReactSelect | |||
| from selenium.common.exceptions import UnexpectedTagNameException | |||
| from selenium.webdriver.common.keys import Keys | |||
There was a problem hiding this comment.
Same here, i don't think we need this anymore
Wolfe1
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Selenium keyword that that first waits for an element to be on the DOM, executes
Focus on it, then it waits for it to be visible, clears it, and then inputs text.
Subsequently, it selects the first item in the search dropdown.