Skip to content

Commit 1180b49

Browse files
6by9pelwell
authored andcommitted
media: i2c: imx290: Register 0x3011 varies between imx327 and imx290
Commit f2055c1 upstream. Reviewing the datasheets, register 0x3011 is meant to be 0x02 on imx327 and 0x00 on imx290. Move it out of the common registers, and set it appropriately in the sensor specific sections. (Included for imx290 to be explicit, rather than relying on the default value). Fixes: 2d41947 ("media: i2c: imx290: Add support for imx327 variant") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
1 parent b3dd7e8 commit 1180b49

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/media/i2c/imx290.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,14 +270,14 @@ static const struct cci_reg_sequence imx290_global_init_settings[] = {
270270
{ IMX290_WINWV, 1097 },
271271
{ IMX290_XSOUTSEL, IMX290_XSOUTSEL_XVSOUTSEL_VSYNC |
272272
IMX290_XSOUTSEL_XHSOUTSEL_HSYNC },
273-
{ CCI_REG8(0x3011), 0x02 },
274273
{ CCI_REG8(0x3012), 0x64 },
275274
{ CCI_REG8(0x3013), 0x00 },
276275
};
277276

278277
static const struct cci_reg_sequence imx290_global_init_settings_290[] = {
279278
{ CCI_REG8(0x300f), 0x00 },
280279
{ CCI_REG8(0x3010), 0x21 },
280+
{ CCI_REG8(0x3011), 0x00 },
281281
{ CCI_REG8(0x3016), 0x09 },
282282
{ CCI_REG8(0x3070), 0x02 },
283283
{ CCI_REG8(0x3071), 0x11 },
@@ -331,6 +331,7 @@ static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = {
331331
};
332332

333333
static const struct cci_reg_sequence imx290_global_init_settings_327[] = {
334+
{ CCI_REG8(0x3011), 0x02 },
334335
{ CCI_REG8(0x309e), 0x4A },
335336
{ CCI_REG8(0x309f), 0x4A },
336337
{ CCI_REG8(0x313b), 0x61 },

0 commit comments

Comments
 (0)