Skip to content

Commit f2055c1

Browse files
6by9mchehab
authored andcommitted
media: i2c: imx290: Register 0x3011 varies between imx327 and imx290
Reviewing the datasheets, register 0x3011 is meant to be 0x02 on imx327 and 0x00 on imx290. Move it out of the common registers, and set it appropriately in the sensor specific sections. (Included for imx290 to be explicit, rather than relying on the default value). Fixes: 2d41947 ("media: i2c: imx290: Add support for imx327 variant") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
1 parent ec75fd9 commit f2055c1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/media/i2c/imx290.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,14 +268,14 @@ static const struct cci_reg_sequence imx290_global_init_settings[] = {
268268
{ IMX290_WINWV, 1097 },
269269
{ IMX290_XSOUTSEL, IMX290_XSOUTSEL_XVSOUTSEL_VSYNC |
270270
IMX290_XSOUTSEL_XHSOUTSEL_HSYNC },
271-
{ CCI_REG8(0x3011), 0x02 },
272271
{ CCI_REG8(0x3012), 0x64 },
273272
{ CCI_REG8(0x3013), 0x00 },
274273
};
275274

276275
static const struct cci_reg_sequence imx290_global_init_settings_290[] = {
277276
{ CCI_REG8(0x300f), 0x00 },
278277
{ CCI_REG8(0x3010), 0x21 },
278+
{ CCI_REG8(0x3011), 0x00 },
279279
{ CCI_REG8(0x3016), 0x09 },
280280
{ CCI_REG8(0x3070), 0x02 },
281281
{ CCI_REG8(0x3071), 0x11 },
@@ -329,6 +329,7 @@ static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = {
329329
};
330330

331331
static const struct cci_reg_sequence imx290_global_init_settings_327[] = {
332+
{ CCI_REG8(0x3011), 0x02 },
332333
{ CCI_REG8(0x309e), 0x4A },
333334
{ CCI_REG8(0x309f), 0x4A },
334335
{ CCI_REG8(0x313b), 0x61 },

0 commit comments

Comments
 (0)