Skip to content

Can't delete container or element inside container - #169

Merged
akaDuality merged 1 commit into
mainfrom
168-cant-delete-container-or-element-inside-container
Jan 1, 2023
Merged

akaDuality merged 1 commit into
mainfrom
168-cant-delete-container-or-element-inside-container

Conversation

@drucelweisse

Copy link
Copy Markdown
Collaborator

closes #168

Added method to array of any AccessibilityView

wrap document method to use them

wrote some deletion tests

@drucelweisse drucelweisse linked an issue Dec 30, 2022 that may be closed by this pull request
@drucelweisse drucelweisse self-assigned this Dec 30, 2022
@drucelweisse

drucelweisse commented Dec 30, 2022 •

Copy link
Copy Markdown
Collaborator Author
  1. Should we delete container if it becomes empty after element deletion?
  2. Should we delete container with children or ungroup before deletion? (probably it just for ungroup function)

@drucelweisse

Copy link
Copy Markdown
Collaborator Author

And as well found bug where didSet property observer on VODesignDocument.controls doesn't know about A11yContainer children deletion. And undo doesn't work

@akaDuality
akaDuality merged commit 0f50062 into main Jan 1, 2023
@akaDuality
akaDuality deleted the 168-cant-delete-container-or-element-inside-container branch January 1, 2023 06:24
@akaDuality

Copy link
Copy Markdown
Member
  1. I expect that container is important and shouldn't be deleted automatically
  2. We should add ungrouping button firstly :D

I'm investigating undo function right now, probably will fix the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't delete container or element inside container

2 participants