Convert interactive divs to semantic buttons #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert expand/collapse divs to buttons with ARIA attributes - Convert dropdown triggers to buttons with proper ARIA roles - Convert sortable table headers to use button elements - Add aria-expanded, aria-controls, aria-label to expand buttons - Add aria-haspopup, aria-expanded, aria-controls to dropdowns - Change dropdown menu from divs to ul/li with proper roles - Add scope="col" to all table headers - Add screen reader only label for expand column - Add .sr-only utility class for screen reader only content - Style buttons to maintain visual appearance - Add proper focus indicators to all interactive elements WCAG: 2.1.1 Keyboard (Level A) All interactive elements are now keyboard accessible and properly announced by screen readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Changes
<button>elements<button>elements<button>elementsaria-expanded,aria-controls,aria-labelto expand buttonsaria-haspopup,aria-expanded,aria-controlsto dropdowns<ul>/<li>with proper ARIA rolesscope="col"to all table headers.sr-onlyutility class for screen reader only contentWCAG Compliance
2.1.1 Keyboard (Level A) - All functionality must be available from keyboard
Testing
Screenshots
Before: Divs with
tabindex="-1"- completely inaccessible to keyboard usersAfter: Semantic buttons with proper ARIA - fully keyboard accessible