fix: Correct broken UIA method implementation that was incompatible with Windows 11 ATs #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my Windows 11 machine (version 22000) and is working correctly. |
Member
|
@mwcampbell CI is failing. Can you please fix clippy? |
DataTriny
approved these changes
Dec 17, 2022
Member
DataTriny
left a comment
DataTriny
left a comment
There was a problem hiding this comment.
Fine. Maybe rebase just to be safe.
…ith Windows 11 ATs
mwcampbell
force-pushed
the
win11-text-fix
branch
from
081bccd to
bc9ea53
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevented Narrator on Windows 11 from reading characters, selection changes, and possibly other things. It might have also affected other assistive technologies that use the same newer UI Automation API that was introduced in Windows 11 and is now being used by Narrator.
fixes #189