-
Notifications
You must be signed in to change notification settings - Fork 88
feat: Text support on macOS #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm aware that the new functions for converting to and from indices are O(n), where n is the number of lines or even characters. I know this won't scale to huge chunks of text, but I've decided not to bother with caching or the like until we know that we need it. After all, cache invalidation is one of the hardest problems in computer science. |
|
I don't even think AppKit bothers with caching as far as that goes, because when in a large text field, pressing command+down to try to jump to the end causes the application to lock up for a good while. If not lock up, at the very least, make VoiceOver think it went not responding. I'm unsure if it also blows up for sighted users, but I doubt it. |
DataTriny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, but I'd prefer if someone with MacOS development knowledge could have a look.
|
@spencerudnick Can you please review this one? |
rain-sk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, everything looks good to me. Though I had one question about claiming to support setAccessibilityValue: without actually implementing it.
…et expose formatting, and VO can use a plain string as a vallback
825efee to
2831f10
Compare
This should be on par with the Windows adapter, meaning support for single-line and multi-line edit controls, but without exposing text formatting attributes or other rich text features. To test with a real toolkit implementation, use this egui branch. egui itself required only one minor fix, which is already merged; the existing integration in egui that was tested with the Windows adapter was mostly fine already.