Skip to content

Conversation

JosuaKrause
Copy link
Contributor

@JosuaKrause JosuaKrause commented Jan 4, 2022

What does this PR do?

Add a minor api version to enable old behavior (e.g., old column names).

Changes

  • minor api version
  • use has_version to decide column names

Before reviewing

  • Are there any linked PRs?
  • Did you test this PR?
  • Is there any migration or seeding necessary?
  • Did you add api to only one of the language (python/typescript)?

Links:

How did you test this PR?

Migration / seed steps

New API added that not implemented in other languages

If your answer is yes, please also update the todo_api.txt at where the API is missing.

Copy link

@mahadeveaswar mahadeveaswar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JosuaKrause JosuaKrause merged commit 85f6aca into master Jan 4, 2022
@JosuaKrause JosuaKrause deleted the jk-minor-version branch January 4, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants