Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Castle.Core from 5.1.1 to 5.2.1 in /src #233

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 16, 2025

Bumps Castle.Core from 5.1.1 to 5.2.1.

Release notes

Sourced from Castle.Core's releases.

5.2.1

(Note: Version 5.2.0 was skipped due to issues with the automated CI release process. This release was delayed until March 9th 2025.)

Enhancements

  • Two new generic method overloads proxyGenerator.CreateClassProxy<TClass>([options], constructorArguments, interceptors) (@​backstromjoel, #636)
  • Allow specifying which attributes should always be copied to proxy class by adding attribute type to AttributesToAlwaysReplicate. Previously only non-inherited, with Inherited=false, attributes were copied. (@​shoaibshakeel381, #633)
  • Support for C# 8+ default interface methods in interface and class proxies without target (@​stakx, #661)
  • DynamicProxy's public API has been augmented with nullable reference type annotations (@​stakx, #668)

Bugfixes

  • ArgumentException: "Could not find method overriding method" with overridden class method having generic by-ref parameter (@​stakx, #657)
  • ArgumentException: "Cannot create an instance of TEnum because Type.ContainsGenericParameters is true" caused by Enum constraint on method out parameter (@​stakx, #658)
Changelog

Sourced from Castle.Core's changelog.

5.2.1 (2025-03-09)

(Note: Version 5.2.0 was skipped due to issues with the automated CI release process.)

Enhancements:

  • Two new generic method overloads proxyGenerator.CreateClassProxy<TClass>([options], constructorArguments, interceptors) (@​backstromjoel, #636)
  • Allow specifying which attributes should always be copied to proxy class by adding attribute type to AttributesToAlwaysReplicate. Previously only non-inherited, with Inherited=false, attributes were copied. (@​shoaibshakeel381, #633)
  • Support for C# 8+ default interface methods in interface and class proxies without target (@​stakx, #661)
  • DynamicProxy's public API has been augmented with nullable reference type annotations (@​stakx, #668)

Bugfixes:

  • ArgumentException: "Could not find method overriding method" with overridden class method having generic by-ref parameter (@​stakx, #657)
  • ArgumentException: "Cannot create an instance of TEnum because Type.ContainsGenericParameters is true" caused by Enum constraint on method out parameter (@​stakx, #658)
Commits
  • 4d62205 Update changelog for 5.2.1 release
  • 28b8715 Dispose keyEnumerator
  • f372c2c Optimize array usage, plus other minor tweaks
  • 17fd99c Update changelog for 5.2.0 release
  • 00642c9 Merge pull request #668 from stakx/enhancement/nullable-reference-type-annota...
  • 7122b6c Update changelog
  • b972aaf Update ref/ contract files
  • 88eb851 Add NRT annotations for public API
  • 3374796 Fix GitHub Actions job failures (#682)
  • a3e629b Merge pull request #661 from stakx/enhancements/default-interface-members
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @piotrzajac.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • Chores
    • Upgraded a core dependency to its latest version, incorporating bug fixes and performance improvements that help enhance overall stability and reliability.

@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Mar 16, 2025
Copy link

coderabbitai bot commented Mar 16, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the Castle.Core package reference in several project files. In all affected projects, the version has been upgraded from 5.1.1 to 5.2.1. This dependency update applies to both test and core projects within the repository without modifying any other configuration or dependency settings.

Changes

File(s) Change Summary
src/Objectivity.AutoFixture.XUnit2...*.csproj Updated Castle.Core package reference from 5.1.1 to 5.2.1

Poem

I'm a rabbit with a joyful heart,
Upgrading packages is a work of art.
From version 5.1.1 I did depart,
Now 5.2.1 gives a brand new start.
Hopping along with a skip and a smile,
I celebrate these changes in true rabbit style!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c7ed72b) to head (329d199).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        39    +3     
  Lines          408       424   +16     
  Branches        55        55           
=========================================
+ Hits           408       424   +16     
Flag Coverage Δ
unittests 99.76% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@piotrzajac
Copy link
Collaborator

@coderabbitai summary

Copy link

coderabbitai bot commented Mar 16, 2025

✅ Actions performed

Summary regeneration triggered.

@piotrzajac
Copy link
Collaborator

@coderabbitai please ensure if all references to Castle.Core were updated

Copy link

coderabbitai bot commented Mar 16, 2025

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find all .csproj files that reference Castle.Core and check their versions
echo "Checking .csproj files for Castle.Core references:"
find . -name "*.csproj" -type f -exec grep -l "Castle.Core" {} \; | while read -r file; do
  echo "File: $file"
  grep -A 2 "Castle.Core" "$file" | grep -E "Version|version"
done

echo -e "\nChecking for packages.config files with Castle.Core references:"
find . -name "packages.config" -type f -exec grep -l "Castle.Core" {} \; | while read -r file; do
  echo "File: $file"
  grep "Castle.Core" "$file"
done

echo -e "\nSearching for any other files that might reference Castle.Core version:"
grep -r --include="*.cs" --include="*.config" --include="*.props" --include="*.targets" "Castle.Core.*5.1.1" .

Length of output: 4696


🏁 Script executed:

#!/bin/bash
# Additional checks for Castle.Core references

echo "Checking for solution files with any Castle.Core references:"
find . -name "*.sln" -type f -exec grep -l "Castle.Core" {} \;

echo -e "\nChecking for paket files with Castle.Core references:"
find . -name "paket.*" -type f -exec grep -l "Castle.Core" {} \;

echo -e "\nChecking for Docker files with Castle.Core references:"
find . -name "Dockerfile*" -type f -exec grep -l "Castle.Core" {} \;

echo -e "\nChecking for any references to the old Castle.Core version anywhere:"
grep -r "Castle.Core.*5.1" --include="*.*" .

Length of output: 784


@piotrzajac I've checked all references to Castle.Core throughout the repository and can confirm that all have been updated from version 5.1.1 to version 5.2.1. Here's what I found:

All 7 project files now reference Castle.Core version 5.2.1:

  • Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.Tests.csproj
  • Objectivity.AutoFixture.XUnit2.AutoFakeItEasy.csproj
  • Objectivity.AutoFixture.XUnit2.AutoMoq.Tests.csproj
  • Objectivity.AutoFixture.XUnit2.AutoMoq.csproj
  • Objectivity.AutoFixture.XUnit2.AutoNSubstitute.Tests.csproj
  • Objectivity.AutoFixture.XUnit2.AutoNSubstitute.csproj
  • Objectivity.AutoFixture.XUnit2.Core.Tests.csproj

I found no other references to Castle.Core in packages.config files, solution files, or any other files in the repository.

There are no remaining references to the old version 5.1.1 anywhere in the codebase.

Bumps [Castle.Core](https://github.com/castleproject/Core) from 5.1.1 to 5.2.1.
- [Release notes](https://github.com/castleproject/Core/releases)
- [Changelog](https://github.com/castleproject/Core/blob/master/CHANGELOG.md)
- [Commits](castleproject/Core@v5.1.1...v5.2.1)

---
updated-dependencies:
- dependency-name: Castle.Core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/src/Castle.Core-5.2.1 branch from cc2da64 to 329d199 Compare March 16, 2025 20:11
@piotrzajac
Copy link
Collaborator

@dependabot squash and merge

@dependabot dependabot bot merged commit 8e5249b into master Mar 16, 2025
19 checks passed
@dependabot dependabot bot deleted the dependabot/nuget/src/Castle.Core-5.2.1 branch March 16, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants