Conversation
ermalkaleci
reviewed
Mar 27, 2025
| const newBatch: HexString[] = [] | ||
|
|
||
| for (const key of batch) { | ||
| const res = await this.#db.queryStorage(this.#at, key) |
Collaborator
There was a problem hiding this comment.
it will be better if we add additional api to check existing keys in batches
Member
Author
There was a problem hiding this comment.
it is not too slow to make 1000 requests to sqlite but yeah we can improve it #899
ermalkaleci
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #897
this don't eliminate getKeysPaged call which requires we store fetch ranged in db but should significantly reduce RPC requests with a prefetched db