Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved build release script #1753

Merged
merged 3 commits into from
Jan 14, 2022
Merged

improved build release script #1753

merged 3 commits into from
Jan 14, 2022

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Jan 6, 2022

Improved script to build release WASM and publishing them.

Closes #1722

@syan095 syan095 closed this Jan 7, 2022
@syan095 syan095 reopened this Jan 7, 2022
@syan095 syan095 marked this pull request as ready for review January 7, 2022 06:23
@syan095
Copy link
Contributor Author

syan095 commented Jan 7, 2022

I created a fork to test this script:
https://github.com/syan095/Acala/actions/workflows/publish-release.yml

@ermalkaleci
Copy link
Contributor

I had to run srtool step manually to get the expected output, I don't think this will work. I guess rest is the same, right?

@syan095
Copy link
Contributor Author

syan095 commented Jan 9, 2022

I had to run srtool step manually to get the expected output, I don't think this will work. I guess rest is the same, right?

Yeah on my fork the script ran all the way to Pinata upload without problem. I think the new github action for srtool takes care of all the setups

@syan095 syan095 requested a review from zjb0807 January 9, 2022 21:32
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #1753 (fa8aa32) into master (6c7f819) will increase coverage by 4.15%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   66.91%   71.07%   +4.15%     
==========================================
  Files         224      219       -5     
  Lines       19764    20991    +1227     
==========================================
+ Hits        13226    14920    +1694     
+ Misses       6538     6071     -467     
Impacted Files Coverage Δ
ecosystem-modules/compound-cash/src/lib.rs 0.00% <0.00%> (-7.15%) ⬇️
ecosystem-modules/compound-cash/src/mock.rs 100.00% <ø> (ø)
ecosystem-modules/ren/renvm-bridge/src/mock.rs 60.00% <0.00%> (+10.00%) ⬆️
inspect/src/lib.rs 0.00% <ø> (-35.78%) ⬇️
modules/asset-registry/src/weights.rs 0.00% <0.00%> (ø)
modules/cdp-treasury/src/weights.rs 0.00% <0.00%> (ø)
modules/collator-selection/src/mock.rs 94.59% <0.00%> (+0.15%) ⬆️
modules/dex/src/mock.rs 100.00% <ø> (+7.89%) ⬆️
modules/dex/src/weights.rs 0.00% <0.00%> (ø)
modules/emergency-shutdown/src/mock.rs 50.00% <0.00%> (ø)
... and 320 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486d5bc...fa8aa32. Read the comment docs.

@xlc xlc merged commit 8bd22c5 into master Jan 14, 2022
@xlc xlc deleted the improve-release branch January 14, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve release build process
3 participants