Rep001 2 hooks #811
Closed
Rep001 2 hooks #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 21, 2019 15:27
-stop early on test fail (mirrors stop early on build fail) -do we want stop-on-fail config settings for variants, tests?
…ring pre-install/release -show summary of all tests at end of build/release
-do a little better at cleaning up failed variant installs -current behaviour is OK (state is always valid), but can leave .building files and package version dirs
nerdvegas
commented
Nov 29, 2019
| @@ -353,18 +370,26 @@ def _uid(self): | |||
| class PackageRepositoryManager(object): | |||
There was a problem hiding this comment.
Note: These minor changes weren't really needed as part of this PR - this work was done when I started investigating a different direction. In any case, these changes fix a bug, where repositories would've been cached into an LRU pool that's shared across all instances of this class.
Closed
added 2 commits
December 3, 2019 14:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements pre-install/release running of package tests.
Note that this is not done as a pre-release hook plugin, because the way this works doesn't match up to the places in which these hooks are run.
The way pre-install (and release) tests are run is like so:
_redirected_base) to point back to the true package install locationNote that #807 must be merged before this PR.