py3 iterators conversion #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you confident that all the iteritems->items changes in py2 don't affect performance? If so then I think this is ok, but if there's any doubt then we should instead use our own iteritems() compatibility function - basically this: https://python-future.org/_modules/future/utils.html. |
nerdvegas
reviewed
Sep 13, 2019
| @@ -359,7 +359,7 @@ def _process(value): | |||
|
|
|||
| def _trim(value): | |||
| if isinstance(value, dict): | |||
| for k, v in value.items(): | |||
| for k, v in value.copy().items(): | |||
There was a problem hiding this comment.
list(value.items()) would more closely match convention everywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested performance on some uncached resolves in method. interestingly, py2 performance has not suffered, but py3 performance is not yet reaching py2 performance. Unsure of the reasons yet, but since py2 seems unaffected, I think we should move forward with this when most other py3 PRs are resolved.
I suggest reviewing this PR commit by commit, as each commit only holds one type of change, but the commits are inseparable (pulling only 1 commit at a time will break rez)