Add more logic in the shell detection code to handle a case where the parent PID is zero - #1735
Merged
JeanChristopheMorinPerso merged 1 commit intoMay 12, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
- Coverage 58.30% 58.30% -0.01%
==========================================
Files 126 126
Lines 17159 17161 +2
Branches 3505 3506 +1
==========================================
+ Hits 10004 10005 +1
Misses 6492 6492
- Partials 663 664 +1 ☔ View full report in Codecov by Sentry. |
|
I confirm this resolved #1732 for me. ps: Someone needs to check out the macos py3.7 CI environment. It seems pretty broken. |
Member
Author
|
Thanks @darkvertex for confirming! As for the macos builds, we'll have to fix them. The failures are caused by the new default Anyway, I'll probably fix the macos thing in another PR. |
… parent PID is zero. This can happen when run from within a docker container with a non-interactive shel. Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
force-pushed
the
fix_pid_out_of_range_docker
branch
from
May 12, 2024 16:13
400d45d to
3f97be0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1732
Add more logic in the shell detection code to handle a case where the parent PID is zero. This can happen when run from within a docker container with a non-interactive shell.
This was not necessarily a hard error. rez would just print an annoying error.
Before:
After: