Add symlink locking for filesystems that do not support hardlinks - #1708
Merged
JeanChristopheMorinPerso merged 3 commits intoApr 13, 2024
Merged
JeanChristopheMorinPerso merged 3 commits into
JeanChristopheMorinPerso merged 3 commits into
Conversation
cfxegbert
force-pushed
the
symlink-locking
branch
from
April 5, 2024 00:05
2a85f70 to
f84bf99
Compare
JeanChristopheMorinPerso
requested changes
Apr 6, 2024
JeanChristopheMorinPerso
left a comment
JeanChristopheMorinPerso
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I left two nitpick comments in the docs.
JeanChristopheMorinPerso
approved these changes
Apr 8, 2024
JeanChristopheMorinPerso
left a comment
JeanChristopheMorinPerso
left a comment
Member
There was a problem hiding this comment.
Thank you @cfxegbert!
Member
|
@cfxegbert can you fix the DCO thing please? You can follow the instructions at https://github.com/AcademySoftwareFoundation/rez/pull/1708/checks?check_run_id=23579052094. |
cfxegbert
force-pushed
the
symlink-locking
branch
from
April 8, 2024 21:08
e3f988f to
cca80ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1708 +/- ##
=======================================
Coverage 58.27% 58.27%
=======================================
Files 126 126
Lines 17157 17157
Branches 3504 3504
=======================================
Hits 9998 9998
Misses 6494 6494
Partials 665 665 ☔ View full report in Codecov by Sentry. |
Add symlink locking for filesystems that do not support hardlinks Signed-off-by: Robert Minsk <robertminsk@yahoo.com>
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com> Signed-off-by: Robert Minsk <38872275+cfxegbert@users.noreply.github.com> Signed-off-by: Robert Minsk <robertminsk@yahoo.com>
Signed-off-by: Robert Minsk <robertminsk@yahoo.com>
JeanChristopheMorinPerso
force-pushed
the
symlink-locking
branch
from
April 13, 2024 19:01
fce9d1c to
d45e5d3
Compare
Member
|
(I rebased the branch to fix a conflict) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our environment we are using a StorNext file server over Samba on our Mac OSX machines. Mounting over Samba does not allow creating hardlinks. The work done in #903 adds the ability to explicitly use mkdir instead of hardlinks. mkdir may not be an atomic operation on non-local filesystems.
See https://www.mail-archive.com/freebsd-hackers@freebsd.org/msg20456.html