Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Orderers now apply to variants #1684

Merged
merged 13 commits into from
Mar 29, 2024
Merged

Package Orderers now apply to variants #1684

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cde1475
Package Orderers now apply to variants
isohedronpipeline Mar 15, 2024
6288676
flake8 fix
isohedronpipeline Mar 17, 2024
1ff6473
Apply suggestions from code review
isohedronpipeline Mar 27, 2024
961f772
Apply notes from review
isohedronpipeline Mar 27, 2024
7566066
Added another Sortable object return type
isohedronpipeline Mar 27, 2024
0359726
Update src/rez/package_order.py
isohedronpipeline Mar 28, 2024
9363ced
Update src/rez/package_order.py
isohedronpipeline Mar 28, 2024
b7338fc
Update src/rez/package_order.py
isohedronpipeline Mar 28, 2024
f5286bc
Update src/rez/package_order.py
isohedronpipeline Mar 28, 2024
7acf42f
Update src/rez/package_order.py
isohedronpipeline Mar 28, 2024
825476f
Updated example to show that package orderers apply to variants
isohedronpipeline Mar 29, 2024
093c899
Update src/rez/rezconfig.py
JeanChristopheMorinPerso Mar 29, 2024
2993f66
Flake8 fix
isohedronpipeline Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/rez/package_order.py 
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
Signed-off-by: Ben Andersen <156872503+isohedronpipeline@users.noreply.github.com>
  • Loading branch information
@isohedronpipeline @JeanChristopheMorinPerso
isohedronpipeline and JeanChristopheMorinPerso authored Mar 28, 2024
commit f5286bccc45d6bb5185e4acc5cdab3bb3f5b465a
2 changes: 1 addition & 1 deletion src/rez/package_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ def singleton(cls):

@staticmethod
def _to_orderer(orderer: Union[dict, PackageOrder]) -> PackageOrder:
if not isinstance(orderer, PackageOrder):
if isinstance(orderer, dict):
orderer = from_pod(orderer)
return orderer

Expand Down