Add utility functions to rename a file or folder src to dst with retrying.

[loonghao]

This PR is try to fix #1665

[JeanChristopheMorinPerso]

Thanks @loonghao for submitting this PR. My main concern right now is speed. Starting a subprocess on Windows usually adds a noticeable overhead.

Could the code first try to os.rename and only fallback to the subprocess method if it's running on windows and the error is "WinError 5" or something like that?

Also, it would be great if you could add tests to cover all cases covered by the change.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.03%. Comparing base (91db537) to head (dafcd6c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
+ Coverage   57.99%   58.03%   +0.03%     
==========================================
  Files         128      128              
  Lines       17088    17102      +14     
  Branches     3502     3504       +2     
==========================================
+ Hits         9911     9925      +14     
  Misses       6509     6509              
  Partials      668      668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[loonghao]

@JeanChristopheMorinPerso I have updated the code and added a unit test for this function. Please take another look. Thanks.

[JeanChristopheMorinPerso]

Thanks! There is a bug in the code and I think we can add more tests.

[loonghao]

Thanks! There is a bug in the code and I think we can add more tests.

@JeanChristopheMorinPerso I have updated the code and added more unit tests. Please take another look.

Thanks.

[JeanChristopheMorinPerso]

Thanks @loonghao ! This should hopefully be my last batch of comments.

[loonghao]

Thanks @loonghao ! This should hopefully be my last batch of comments.

@JeanChristopheMorinPerso I have made all the changes based on your feedback and addressed all the comments. Could you please take another look. Thanks!

[JeanChristopheMorinPerso]

Looks good to me. Thanks for taking the time to fix this and address all my comments! If everything goes as planned, this will be released in the next release.