[python] more ImageConverter bindings #223
Draft
+455
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 82.70% 83.31% +0.60%
==========================================
Files 11 11
Lines 2151 2151
Branches 327 327
==========================================
+ Hits 1779 1792 +13
+ Misses 372 359 -13 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
soswow
reviewed
Dec 10, 2025
| return result; | ||
| }, | ||
| []( ImageConverter::Settings &settings, const std::vector<int> &box ) { | ||
| if ( box.size() == 4 ) |
Contributor
There was a problem hiding this comment.
what happens if user doesn't provide array of 4?
soswow
reviewed
Dec 10, 2025
| assert abs(wb[3] - 0) < 0.0001 | ||
|
|
||
| print("get_IDT_matrix", converter.get_IDT_matrix()) | ||
| print("get_CAT_matrix", converter.get_CAT_matrix()) |
soswow
reviewed
Dec 10, 2025
Comment on lines
+176
to
+177
| except Exception: | ||
| pytest.fail(Exception) |
Contributor
There was a problem hiding this comment.
Should it be:
except Exception as e:
pytest.fail(f"Unexpected exception: {e}")
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contains the python bindings for the rest of the ImageConverter functionality, except of the ones requiring OIIO objects.
OIIO doesn't currently have nanobind bindings, we'll add those after OIIO switches from pybind to nanobind.
Tests
There are unit tests for all added bindings.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.