OpenEXRCore: avoid direct dependency on imath#2198
Merged
cary-ilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Nov 17, 2025
Merged
OpenEXRCore: avoid direct dependency on imath#2198cary-ilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
cary-ilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
All other Core code uses internal_coding.h functions half_to_float & float_to_half, in order to make it compile when IMath is not present at all, follow the same pattern. This dependency was accidentally introduced in AcademySoftwareFoundation#2174 and AcademySoftwareFoundation#2126 Signed-off-by: Aras Pranckevicius <aras@nesnausk.org>
cary-ilm
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other Core code uses
internal_coding.hfunctionshalf_to_float&float_to_half, in order to make it compile when IMath is not present at all; follow the same pattern. This dependency was accidentally introduced in #2174 and #2126. For any regular OpenEXR build this is not a problem; only becomes a problem if someone manually builds OpenEXRCore without IMath.