Suppress deprecation warnings for isOptimizationEnabled and standard attributes #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes The methods are deprecated for use in application code, but no reason to pollute the build with warnings about the remaining internal usage. Signed-off-by: Cary Phillips <cary@ilm.com>
|
@peterhillman, could you take a look at this? |
|
We should be able to remove testOptimized completely. @kdt3rd is testOptimizedInterleavePatterns also unnecessary now? That was originally there to test functionality of code that is now removed, but is it worth keeping it as a test that verifies that the library correctly unpacks into various arrangements of interleaved frame buffers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods are deprecated for use in application code, but no reason to pollute the build with warnings about the remaining internal usage.
Also, InputPart::isOptimizationEnabled() presumably should be marked as deprecated, since all it does is call the deprecated InputFile::isOptimizationEnabled()