Add pybind11 subdirectory only if building python bindings #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshula
approved these changes
Mar 29, 2021
Collaborator
meshula
left a comment
meshula
left a comment
There was a problem hiding this comment.
good call, no need to bring pybind11 along on non-python builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
We were adding pybind11 as a subdirectory in cmake even if the building python bindings was disabled. This PR conditionally adds pybind11.
To build the Java bindings for android we do not need the python bindings. While building for 32-bit android I was getting an error (here) saying that the pybind11 cmake was looking for 32-bit python, but couldn't find it. The easy solution is to just disable building python bindings and not search for python at all. I've tested this and am able to build for 32-bit.