Enable xges unit tests on all platform/python versions #894
Conversation
thiblahute
force-pushed
the
xges_test_windows_py2
branch
4 times, most recently
from
1ca9328 to
94df91c
Compare
|
cc @ssteinbach |
ssteinbach
left a comment
ssteinbach
left a comment
There was a problem hiding this comment.
Nice, just one question about the import. Thanks for the quick turnaround time!
setup.py
Outdated
|
|
||
| INSTALL_REQUIRES = [ | ||
| 'pyaaf2==1.4.0', | ||
| 'future', |
There was a problem hiding this comment.
Is this to enable the builtins module only in python2? If so note that on line 59 there are some python2 specific dependencies, this could go there.
There was a problem hiding this comment.
I think it is needed for both python2 and python3.
There was a problem hiding this comment.
And sorry to not answer last week, I was away. Also I think it was simpler to do it the way we did it in the end :-)
There was a problem hiding this comment.
Looks like its in python3: https://docs.python.org/3/library/builtins.html
There was a problem hiding this comment.
Could you add a comment saying "# enables the builtins module on python2"
ssteinbach
left a comment
ssteinbach
left a comment
There was a problem hiding this comment.
My one request is that this gets a comment in the setup.py noting that this is for the builtins module specifically used by the XGES adapter. Otherwise looks great, thanks for the quick turnaround time!
thiblahute
force-pushed
the
xges_test_windows_py2
branch
from
94df91c to
b2c048d
Compare
Fixing minor confusion between int and longs
thiblahute
force-pushed
the
xges_test_windows_py2
branch
from
b2c048d to
77d851f
Compare
|
Thanks for the review! |
2 participants
After #873 was merged, this enables xges adapter tests on the same platforms/python version as other adapters.