Skip to content

CMake: Fix message() types #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssteinbach merged 6 commits into from
Feb 17, 2021
Merged

CMake: Fix message() types #879

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
481e37b
CMake: Fix message() types and a set()
Simran-B Feb 8, 2021
c3592d0
Use message(STATUS ...), minor cleanup
Simran-B Feb 9, 2021
f18a941
Minor tweak to message text
Simran-B Feb 10, 2021
a34b5e4
Undo change to comment about install paths
Simran-B Feb 17, 2021
4bbb97c
Update CMakeLists.txt
ssteinbach Feb 17, 2021
0008d11
Merge branch 'master' into cmake-typos-2021-02-09
ssteinbach Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,27 @@ project(OpenTimelineIO VERSION ${OTIO_VERSION} LANGUAGES C CXX)
# maintenance and troubleshooting

# Installation options
option(OTIO_CXX_INSTALL "Install the cpp bindings" ON)
option(OTIO_PYTHON_INSTALL "Install the python bindings" ON)
option(OTIO_CXX_INSTALL "Install the C++ bindings" ON)
option(OTIO_PYTHON_INSTALL "Install the Python bindings" ON)
option(OTIO_DEPENDENCIES_INSTALL "Install OTIO's C++ header dependencies (any and nonstd)" ON)
option(OTIO_INSTALL_COMMANDLINE_TOOLS "Install the OTIO command line tools" ON)
set(OTIO_PYTHON_INSTALL_DIR "" CACHE STRING "Python installation dir (such as the site-packages dir)")

# Build options
option(OTIO_SHARED_LIBS "Build shared if ON, static if OFF" ON)
option(OTIO_CXX_COVERAGE "Invoke code coverage if gcov is available" OFF)
option(OTIO_SHARED_LIBS "Build shared if ON, static if OFF" ON)
option(OTIO_CXX_COVERAGE "Invoke code coverage if lcov/gcov is available" OFF)
option(OTIO_AUTOMATIC_SUBMODULES "Fetch submodules automatically" ON)

#------------------------------------------------------------------------------
# Set option dependent variables

if(OTIO_PYTHON_INSTALL)
# reconcile install directories for builds incorporating python in order
# reconcile install directories for builds incorporating Python in order
# that default behaviors match a reasonable expectation, as follows:
#
# if nothing has been set,
# Python: ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}/opentimelineio

# if nothing has been set,
# Python: ${Python_SITEARCH}/opentimelineio
# C++: ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}/opentimelineio/cxx-sdk
# if only CMAKE_INSTALL_PREFIX has been set,
# Python: ${CMAKE_INSTALL_PREFIX}/opentimelineio/python
Expand All @@ -53,17 +54,17 @@ if(OTIO_PYTHON_INSTALL)
# Python: ${OTIO_PYTHON_INSTALL_DIR}/opentimelineio
# C++: ${OTIO_PYTHON_INSTALL_DIR}/opentimelineio/cxx-sdk
#
# In a python install, the dylibs/dlls need to be installed where __init.py
# can find them, rather as part of the C++ sdk package; so the variable
# In a Python install, the dylibs/dlls need to be installed where __init__.py
# can find them, rather as part of the C++ SDK package; so the variable
# OTIO_RESOLVED_CXX_DYLIB_INSTALL_DIR indicates where that is.
#
if(OTIO_PYTHON_INSTALL_DIR STREQUAL "" AND CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
# neither install directory supplied from the command line
find_package(Python REQUIRED COMPONENTS Interpreter Development)
set(OTIO_RESOLVED_PYTHON_INSTALL_DIR "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
set(OTIO_RESOLVED_PYTHON_INSTALL_DIR "${Python_SITEARCH}")
set(OTIO_RESOLVED_CXX_INSTALL_DIR "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}/opentimelineio/cxx-sdk")
set(OTIO_RESOLVED_CXX_DYLIB_INSTALL_DIR "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}/opentimelineio")
message(INFO, "OTIO Defaulting both Python and C++ install to ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
message(STATUS "OTIO Defaulting both Python and C++ install to ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
else()
# either python_install or install_prefix have been set
if(OTIO_PYTHON_INSTALL_DIR_INITIALIZED_TO_DEFAULT)
Expand All @@ -72,57 +73,57 @@ if(OTIO_PYTHON_INSTALL)
set(OTIO_RESOLVED_CXX_INSTALL_DIR "${CMAKE_INSTALL_PREFIX}")

# In order to not require setting $PYTHONPATH to point at the .so,
# the shared libraries are installed into the python library
# the shared libraries are installed into the python library
# location.
set(OTIO_RESOLVED_CXX_DYLIB_INSTALL_DIR "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}/opentimelineio")
message(INFO, "OTIO Defaulting Python install to ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
message(INFO, "Note: C++ linkable-shared libraries can be found: ${CMAKE_INSTALL_PREFIX}/opentimelineio")
message(STATUS "OTIO Defaulting Python install to ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
message(STATUS "Note: C++ linkable shared libraries can be found at: ${OTIO_RESOLVED_CXX_INSTALL_DIR}/lib")
else()
# OTIO_PYTHON_INSTALL_DIR was set, so install everything into the python package
set(OTIO_RESOLVED_PYTHON_INSTALL_DIR "${OTIO_PYTHON_INSTALL_DIR}")
set(OTIO_RESOLVED_CXX_INSTALL_DIR "${OTIO_PYTHON_INSTALL_DIR}/opentimelineio/cxx-sdk")
set(OTIO_RESOLVED_CXX_DYLIB_INSTALL_DIR "${OTIO_PYTHON_INSTALL_DIR}/opentimelineio")
message(INFO, "OTIO Defaulting C++ install to ${OTIO_PYTHON_INSTALL_DIR}")
message(STATUS "OTIO Defaulting C++ install to ${OTIO_PYTHON_INSTALL_DIR}")
endif()
endif()
else()
set(OTIO_RESOLVED_CXX_INSTALL_DIR "${CMAKE_INSTALL_PREFIX}")
set(OTIO_RESOLVED_CXX_DYLIB_INSTALL_DIR "${CMAKE_INSTALL_PREFIX}/lib")
message(INFO, "OTIO C++ installing to ${CMAKE_INSTALL_PREFIX}")
message(STATUS "OTIO C++ installing to ${CMAKE_INSTALL_PREFIX}")
endif()

set(CMAKE_INSTALL_INCLUDEDIR "${OTIO_RESOLVED_CXX_INSTALL_DIR}/include")

if(OTIO_SHARED_LIBS)
message(INFO, "Building shared libs.")
message(STATUS "Building shared libs")
set(OTIO_SHARED_OR_STATIC_LIB "SHARED")
else()
message(INFO, "Building static libs.")
message(STATUS "Building static libs")
set(OTIO_SHARED_OR_STATIC_LIB "STATIC")
if (OTIO_PYTHON_INSTALL AND NOT MSVC)
# TODO: add explicit visibility decorations for OpenTime and OpentimelineIO to resolve
# this issue. For reference, there is discussion here: https://gist.github.com/ax3l/ba17f4bb1edb5885a6bd01f58de4d542
message(WARNING, "pybind11 forces visibility flags, used shared libraries instead.")
message(WARNING "pybind11 forces visibility flags, used shared libraries instead.")
endif()
endif()

if(OTIO_CXX_INSTALL)
message(INFO, "Installing C++ bindings to: ${OTIO_RESOLVED_CXX_INSTALL_DIR}")
message(INFO, "Installing C++ dynamic libraries to: ${OTIO_RESOLVED_CXX_DYLIB_INSTALL_DIR}")
message(STATUS "Installing C++ bindings to: ${OTIO_RESOLVED_CXX_INSTALL_DIR}")
message(STATUS "Installing C++ dynamic libraries to: ${OTIO_RESOLVED_CXX_DYLIB_INSTALL_DIR}")

if(OTIO_DEPENDENCIES_INSTALL)
message(INFO, " Installing 'any' and 'nonstd' for C++.. (OTIO_DEPENDENCIES_INSTALL:ON)")
message(STATUS " Installing 'any' and 'nonstd' for C++ (OTIO_DEPENDENCIES_INSTALL=ON)")
else()
message(INFO, " Not installing any and nonstd for C++.. (OTIO_DEPENDENCIES_INSTALL:OFF)")
message(STATUS " Not installing any and nonstd for C++ (OTIO_DEPENDENCIES_INSTALL=OFF)")
endif()
else()
message(INFO, "Install C++ bindings..... OFF")
message(STATUS "Install C++ bindings: OFF")
endif()

if(OTIO_PYTHON_INSTALL)
message(INFO, "Installing Python bindings to: ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
message(STATUS "Installing Python bindings to: ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
else()
message(INFO, "Install Python bindings.. OFF")
message(STATUS "Install Python bindings: OFF")
endif()

#------------------------------------------------------------------------------
Expand Down Expand Up @@ -165,7 +166,7 @@ if (OTIO_AUTOMATIC_SUBMODULES AND NOT DEFINED ENV{TRAVIS})
# make sure that git submodules are up to date when building
find_package(Git QUIET)
if (GIT_FOUND)
message(INFO, "Checking git repo is available:")
message(STATUS "Checking git repo is available:")
execute_process(
# the following command returns true if cwd is in the repo
COMMAND ${GIT_EXECUTABLE} rev-parse --is-inside-work-tree
Expand All @@ -189,7 +190,7 @@ if (OTIO_AUTOMATIC_SUBMODULES AND NOT DEFINED ENV{TRAVIS})
)
if (NOT GIT_UPDATE_SUBMODULES_RESULT EQUAL "0")
message(
FATAL_ERROR
FATAL_ERROR
"git submodule update --init --recursive failed with \
${GIT_UPDATE_SUBMODULES_RESULT}"
)
Expand Down