from_start_end_time_inclusive

[splidje]

Added duration_from_start_end_time_inclusive and range_from_start_end_time_inclusive to RationalTime and TimeRange respectively.

[codecov-io]

Codecov Report

Merging #868 (c96e75e) into master (bcdd9a7) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   84.18%   84.27%   +0.08%     
==========================================
  Files          74       74              
  Lines        3061     3084      +23     
==========================================
+ Hits         2577     2599      +22     
- Misses        484      485       +1     

Flag	Coverage Δ
unittests	84.27% <100.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/opentime/rationalTime.h	88.00% <100.00%> (-0.89%)	⬇️
src/opentime/timeRange.h	100.00% <100.00%> (ø)
...lineio/opentime-bindings/opentime_rationalTime.cpp	97.43% <100.00%> (+0.06%)	⬆️
...imelineio/opentime-bindings/opentime_timeRange.cpp	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdd9a7...c96e75e. Read the comment docs.

[meshula]

looks good to me. Thanks for adding tests!

[ssteinbach]

Really small note to get over the lint failure (to see the lint results locally, run make lint from the top of the source directory)).

Thanks!

[ssteinbach]

This is triggering a lint error for being too long (see: https://github.com/PixarAnimationStudios/OpenTimelineIO/pull/868/checks?check_run_id=1714226672 ). I think you can fix it:

Suggested change

	duration_from_start_end_time_inclusive = RationalTime.duration_from_start_end_time_inclusive
	duration_from_start_end_time_inclusive = (
	RationalTime.duration_from_start_end_time_inclusive
	)

[ssteinbach]

Great, thanks!

[jminor]

@splidje I don't see a CLA from you. Did I miss it? If not, could you send us a signed CLA as documented here: https://opentimelineio.readthedocs.io/en/latest/tutorials/contributing.html

[splidje]

@splidje I don't see a CLA from you. Did I miss it? If not, could you send us a signed CLA as documented here: https://opentimelineio.readthedocs.io/en/latest/tutorials/contributing.html

Apologies! I've sent that over now.

[jminor]

Thanks! Got it.