Hotfix/python cxx libs correct place #853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@jezscha we've landed a substantial fix to the cmake build system (see: #837) -- can you see if that PR addresses this issue as well? Thanks! |
Collaborator
|
As far as we can tell, covered by #837, let us know or feel free to reopen if we missed something. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
Summarize your change.
There was not successful pip installation on windows platform (only one I was testing). The error mentioned in the above issue was persisting. Solution for us was to move all nested files from
cxx-libsto root folder ofopentimelineioin site-packages. The proposed solution is rather work-around as I realize this could be fixed in many more ways. Lets discourse I will be more then happy for any of your suggestion.setup.py:Installclass was created function forcxx_to_rootwhich is moving all content to module root