FCP 7 XML: Fixed resolution of start timecode for certain NTSC rate clips #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinecke
force-pushed
the
fix/ereinecke-830-fix-fcp7-xml-ntsc-start-timecode
branch
from
f435ffc to
d42dda8
Compare
…lements in their rate would not properly inherit the ntsc value from the parent context.
reinecke
force-pushed
the
fix/ereinecke-830-fix-fcp7-xml-ntsc-start-timecode
branch
from
d42dda8 to
b9528e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue in FCP7 XML adapter where timecode objects without
ntscelements in their rate would not properly inherit thentscvalue from the parent context.Most of our code was built around Premiere Pro XML files which explicitly include the
ntscelement in theirrateelements. XML coming from FCP 7 (maybe others) does not do this and would break the start time resolution for clips.This may address the bug described in #830.
Summarize your change.
The main change here is that
timecodeelements are now evaluated in the context of their parent and allow for the FCP 7 XML inheritance patterns.To simplify code paths, I refactored some of the functions around computing a rate float from the fcp two-part
timebaseandntscelements. Very little actual logic changed, just rules for resolving the values withinrateelements.