Skip to content

Prefix _TypeRecord constructor params to avoid shadow warnings #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssteinbach merged 1 commit into from
Oct 28, 2020
Merged

Prefix _TypeRecord constructor params to avoid shadow warnings #825

ssteinbach merged 1 commit into from
Oct 28, 2020

Conversation

@Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Oct 28, 2020

Fixes #822

Summarize your change.

Add underscore to the parameter names to avoid GCC's warnings about shadowing

@Simran-B Simran-B mentioned this pull request Oct 28, 2020
Closed
@ssteinbach ssteinbach merged commit 1b16826 into AcademySoftwareFoundation:master Oct 28, 2020
@ssteinbach
Copy link
Collaborator

ssteinbach commented Oct 28, 2020

Thanks!

@Simran-B Simran-B deleted the patch-1 branch October 29, 2020 09:20
@elsandosgrande elsandosgrande mentioned this pull request Oct 29, 2020
Closed
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meshula meshula meshula approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Public Beta 14

Development

Successfully merging this pull request may close these issues.

_TypeRecord constructor shadow warning with GCC 10

3 participants

@Simran-B @ssteinbach @meshula