Skip to content

Conversation

@thiblahute
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.

Summarize your change.

ImageSequence somehow recently landed but no support was added for the xges format. This implements that support.

Add a list of changes, and note any that might need special attention during review.

Reference associated tests.

  • tests_xges_adapter.AdaptersXGESTest.test_image_sequence_example

@thiblahute thiblahute force-pushed the xges_image_sequence branch 5 times, most recently from 730319b to 55b7992 Compare September 2, 2020 04:34
Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! We don't expect new schemas to be supported in all the contrib adapters at once - so these kinds of pull requests that add support are perfect. Thanks!

@ssteinbach ssteinbach merged commit 11b8445 into AcademySoftwareFoundation:master Sep 2, 2020
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants