Skip to content

Clarify range bounds clusivity #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssteinbach merged 4 commits into from
Mar 23, 2017
Merged

Clarify range bounds clusivity #79

ssteinbach merged 4 commits into from
Mar 23, 2017

Conversation

@ssteinbach
Copy link
Collaborator

@ssteinbach ssteinbach commented Mar 17, 2017

There was some confusion in the codebase about whether end_time on TimeRange was inclusive or exclusive, and there are cases where you want one or the other. So rather than pick a fixed policy (since its computed regardless), end_time was split into:
end_time_inclusive
end_time_exclusive

@ssteinbach ssteinbach added the bug A problem, flaw, or broken functionality. label Mar 17, 2017
@ssteinbach ssteinbach added this to the Alpha 4 milestone Mar 17, 2017
@ssteinbach ssteinbach self-assigned this Mar 17, 2017
@ssteinbach ssteinbach requested review from jminor and reinecke March 17, 2017 23:34
@ssteinbach ssteinbach merged commit 2cfb712 into AcademySoftwareFoundation:master Mar 23, 2017
@ssteinbach ssteinbach deleted the clarify_range_bounds_inclusivity branch April 4, 2017 22:11
@ssteinbach ssteinbach mentioned this pull request May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jminor jminor Awaiting requested review from jminor

@reinecke reinecke Awaiting requested review from reinecke

Assignees

@ssteinbach ssteinbach

Labels

bug A problem, flaw, or broken functionality.

Projects

None yet

Milestone

Alpha 4

Development

Successfully merging this pull request may close these issues.

1 participant

@ssteinbach