Skip to content

Add description for faulty formatted timecode test #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssteinbach merged 1 commit into from
Aug 17, 2020
Merged

Add description for faulty formatted timecode test #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_opentime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,18 @@ def test_timecode_2997(self):
self.assertEqual(t2, t)

def test_faulty_formatted_timecode_24(self):
"""
01:00:13;23 is drop-frame timecode, which only applies for
NTSC rates (24000/1001, 30000/1001, etc). Such timecodes
drop frames to compensate for the NTSC rates being slightly
slower than whole frame rates (eg: 24 fps).
It does not make sense to use drop-frame timecodes for
non-NTSC rates.

This is what we're testing here. When using 24 fps for the
drop-frame timecode 01:00:13;23 we should get a ValueError
mapping internally to the ErrorStatus 'NON_DROPFRAME_RATE'.
"""
with self.assertRaises(ValueError):
otio.opentime.from_timecode('01:00:13;23', 24)

Expand Down