Implementation of post adapter write hook #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 10, 2020 01:11
* Renamed variable in test example file
…ok will need to be handled by user.
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 72 72
Lines 2755 2755
=======================================
Hits 2256 2256
Misses 499 499
Continue to review full report at Codecov.
|
ssteinbach
requested changes
Jun 11, 2020
Suggested change from @ssteinbach Co-authored-by: Stephan Steinbach <61017+ssteinbach@users.noreply.github.com>
Contributor
Author
|
I was a bit quick on the draw, so the first test didn't finish before I pushed the next one. |
…adapter_arguments']` to avoid modifying the original arguments implicitly.
Contributor
Author
|
@ssteinbach |
ssteinbach
approved these changes
Jul 7, 2020
Collaborator
ssteinbach
left a comment
ssteinbach
left a comment
There was a problem hiding this comment.
Awesome, thanks @apetrynet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for "post_adapter_write" hooks.
Post hooks are run after the file is written to disk by an adapter and passes the file path to the hooks through
_filepathkey in theargument_map.Updated unit tests and added example in the hooks docs.