Skip to content

Added support for ImageSequenceReference to example RV plugin #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reinecke merged 3 commits into from
May 28, 2020
Merged

Added support for ImageSequenceReference to example RV plugin #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ecb920
Added support for ImageSequenceReference to the example OTIO RV reade…
avrata Jan 13, 2020
57d75d4
Removed debug print
avrata Jan 14, 2020
fdcda67
Switched to using opentime.to_frames to compute rv's in and out frames
avrata Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions contrib/opentimelineio_contrib/adapters/extern_rv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,15 +309,15 @@ def _write_item(it, to_session, track_kind=None):
)

if not in_frame and not out_frame:
# because OTIO has no global concept of FPS, the rate of the duration is
# used as the rate for the range of the source.
# RationalTime.value_rescaled_to returns the time value of the object in
# time rate of the argument.
in_frame = range_to_read.start_time.value_rescaled_to(
range_to_read.duration
# because OTIO has no global concept of FPS, the rate of the duration
# is used as the rate for the range of the source.
in_frame = otio.opentime.to_frames(
range_to_read.start_time,
rate=range_to_read.duration.rate
)
out_frame = range_to_read.end_time_inclusive().value_rescaled_to(
range_to_read.duration
out_frame = otio.opentime.to_frames(
range_to_read.end_time_inclusive(),
rate=range_to_read.duration.rate
)

src.setCutIn(in_frame)
Expand Down
44 changes: 32 additions & 12 deletions contrib/opentimelineio_contrib/application_plugins/rv/example_otio_reader/otio_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,17 @@ def _create_media_reference(item, track_kind=None):
# Appending blank to media promotes name of audio file in RV
media.append(blank)

return media
elif isinstance(item.media_reference,
otio.schema.ImageSequenceReference):
frame_sub = "%0{n}d".format(
n=item.media_reference.frame_zero_padding
)

media = [
str(item.media_reference.abstract_target_url(symbol=frame_sub))
]

return media
elif isinstance(item.media_reference, otio.schema.GeneratorReference):
if item.media_reference.generator_kind == "SMPTEBars":
Expand Down Expand Up @@ -250,19 +261,28 @@ def _create_item(it, track_kind=None):
if hasattr(it, "media_reference") and it.media_reference:
_add_metadata_to_node(it.media_reference, src)

# because OTIO has no global concept of FPS, the rate of the duration is
# used as the rate for the range of the source.
# RationalTime.value_rescaled_to returns the time value of the object in
# time rate of the argument.
cut_in = range_to_read.start_time.value_rescaled_to(
range_to_read.duration
)
commands.setIntProperty(src + ".cut.in", [int(cut_in)])
in_frame = out_frame = None
if hasattr(it, "media_reference") and it.media_reference:
if isinstance(it.media_reference, otio.schema.ImageSequenceReference):
in_frame, out_frame = \
it.media_reference.frame_range_for_time_range(
range_to_read
)

if not in_frame and not out_frame:
# because OTIO has no global concept of FPS, the rate of the duration
# is used as the rate for the range of the source.
in_frame = otio.opentime.to_frames(
range_to_read.start_time,
rate=range_to_read.duration.rate
)
out_frame = otio.opentime.to_frames(
range_to_read.end_time_inclusive(),
rate=range_to_read.duration.rate
)

cut_out = range_to_read.end_time_inclusive().value_rescaled_to(
range_to_read.duration
)
commands.setIntProperty(src + ".cut.out", [int(cut_out)])
commands.setIntProperty(src + ".cut.in", [in_frame])
commands.setIntProperty(src + ".cut.out", [out_frame])

commands.setFloatProperty(src + ".group.fps",
[float(range_to_read.duration.rate)])
Expand Down