-
Notifications
You must be signed in to change notification settings - Fork 314
Example RV OTIO Writer #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example RV OTIO Writer #623
Conversation
| otio_prop = node_name + ".attributes.otio_metadata" | ||
|
|
||
| # Persist the Node properties as metadata | ||
| node_type = rv.commands.nodeType(node_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GatesARC This is my attempt at persisting the Node metadata as you suggested. Lemme know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
| if rv.commands.propertyExists(otio_prop): | ||
| metadata_str = rv.commands.getStringProperty(otio_prop)[0] | ||
| try: | ||
| metadata.update(json.loads(metadata_str)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JoshBurnell , just thought I would point out some potential changes in #640 (and conversation in #opentimelineio). I think the fix would be as simple as
otio.core.deserialize_json_from_string(metadata_str)
# or.. not sure if it really matters
otio.adapters.read_from_string(metadata_str)
|
Just thought I would comment on this old one from an update from a recent meeting. I have localized this for some testing here at Pixar with some very slight changes and it seems to be working well. There is still some more work that could be done (specifically around the new ImageSequenceReference), but wanted to point out that it's still lives on. |
|
This is the complement of #565 |
|
By complement do you mean 565 was a prerequisite? |
|
No. #565 is the reader, this is the writer. |
This is a recreation of #589
In an attempt to fix some weird rebase issue in a previous PR, I'd deleted my Fork and I lost the link to #589, so I've moved it here.