Skip to content

Conversation

@JoshBurnell
Copy link
Contributor

This is a recreation of #589

In an attempt to fix some weird rebase issue in a previous PR, I'd deleted my Fork and I lost the link to #589, so I've moved it here.

otio_prop = node_name + ".attributes.otio_metadata"

# Persist the Node properties as metadata
node_type = rv.commands.nodeType(node_name)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GatesARC This is my attempt at persisting the Node metadata as you suggested. Lemme know what you think.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

if rv.commands.propertyExists(otio_prop):
metadata_str = rv.commands.getStringProperty(otio_prop)[0]
try:
metadata.update(json.loads(metadata_str))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoshBurnell , just thought I would point out some potential changes in #640 (and conversation in #opentimelineio). I think the fix would be as simple as

otio.core.deserialize_json_from_string(metadata_str)
# or.. not sure if it really matters
otio.adapters.read_from_string(metadata_str)

@reinecke reinecke changed the title Example OTIO Writer Example RV OTIO Writer May 6, 2021
@reinecke reinecke added this to the Backlog milestone May 6, 2021
@avrata
Copy link
Contributor

avrata commented May 27, 2021

Just thought I would comment on this old one from an update from a recent meeting. I have localized this for some testing here at Pixar with some very slight changes and it seems to be working well. There is still some more work that could be done (specifically around the new ImageSequenceReference), but wanted to point out that it's still lives on.

@ssteinbach
Copy link
Collaborator

This is the complement of #565

@meshula
Copy link
Collaborator

meshula commented Oct 26, 2021

By complement do you mean 565 was a prerequisite?

@ssteinbach
Copy link
Collaborator

No. #565 is the reader, this is the writer.

@ssteinbach ssteinbach deleted the branch AcademySoftwareFoundation:master October 27, 2021 17:47
@ssteinbach ssteinbach closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants