Skip to content

Conversation

@avrata
Copy link
Contributor

@avrata avrata commented Sep 24, 2019

Small updates I missed in #565

@avrata avrata force-pushed the rv_application_plugin branch from ae8caae to 733695e Compare September 25, 2019 00:03
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #584   +/-   ##
======================================
  Coverage    81.6%   81.6%           
======================================
  Files          72      72           
  Lines        2729    2729           
======================================
  Hits         2227    2227           
  Misses        502     502
Flag Coverage Δ
#py27 81.58% <ø> (ø) ⬆️
#py36 81.58% <ø> (?)
#py37 81.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c0951...733695e. Read the comment docs.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ssteinbach ssteinbach added this to the Public Beta 12 milestone Sep 30, 2019
@ssteinbach
Copy link
Collaborator

How does this look, @JoshBurnell @eric-desruisseaux-adsk?

@JoshBurnell can you rebase your writer plugin onto this once we land this PR?

Thanks!

@ssteinbach ssteinbach merged commit 2c35608 into AcademySoftwareFoundation:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants