Allow build system to use rapidjson from the system #1859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
For (Linux) distro packaging it is common to use system packages instead of submodules and co.
With this option one can ask to use the system rapidjson with CMake flag instead of maintaining custom patches such as https://build.opensuse.org/projects/KDE:Applications/packages/opentimelineio/files/0001-Use-system-rapidjson.patch?expand=1
Note: if
OTIO_FIND_RAPIDJSONisONbut rapidjson is not found cmake fails. This behavior is different toOTIO_FIND_IMATHwhere it will just continue withsrc/depsas a fallback. However I think if the user explicitly request the system package it makes more sense to fail if not found. In my opinion this should be changed for Imath as well, but that is offtopic for this PR