Remove fcp adapter #1501

apetrynet · 2022-12-14T23:23:11Z

Part of the ongoing effort to move adapters to their own repositories. #1386
Removed fcp xml adapter and related tests.
Auto documentation on adapters is updated.

Signed-off-by: apetrynet <flehnerheener@gmail.com>

…O into extract_adapters

Signed-off-by: apetrynet <flehnerheener@gmail.com>

…ed in a separate PR. Will rebase when merged Signed-off-by: apetrynet <flehnerheener@gmail.com>

Signed-off-by: apetrynet <flehnerheener@gmail.com>

… in tests Signed-off-by: apetrynet <flehnerheener@gmail.com>

Signed-off-by: apetrynet <flehnerheener@gmail.com>

… in tests Signed-off-by: apetrynet <flehnerheener@gmail.com>

…extracted Signed-off-by: apetrynet <flehnerheener@gmail.com>

…dapters # Conflicts: # tests/test_examples.py

Signed-off-by: apetrynet <flehnerheener@gmail.com>

…ole tests. Signed-off-by: apetrynet <flehnerheener@gmail.com>

…t_adapters

Signed-off-by: apetrynet <flehnerheener@gmail.com>

…ole tests. Signed-off-by: apetrynet <flehnerheener@gmail.com>

…fcp_adapter

Signed-off-by: apetrynet <flehnerheener@gmail.com>

codecov-commenter · 2022-12-14T23:36:15Z

Codecov Report

Merging #1501 (012cbc7) into extract_adapters (7a0a8c7) will decrease coverage by 0.95%.
The diff coverage is 100.00%.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           extract_adapters    #1501      +/-   ##
====================================================
- Coverage             78.24%   77.28%   -0.96%     
====================================================
  Files                   190      188       -2     
  Lines                 18816    17644    -1172     
  Branches               3846     3679     -167     
====================================================
- Hits                  14722    13636    -1086     
+ Misses                 2031     1980      -51     
+ Partials               2063     2028      -35

Flag	Coverage Δ
py-unittests	`77.28% <100.00%> (-0.96%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
tests/test_console.py	`95.33% <100.00%> (ø)`
src/opentimelineio/timeline.h	`69.23% <0.00%> (-23.08%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0a8c7...012cbc7. Read the comment docs.

Signed-off-by: apetrynet <flehnerheener@gmail.com>

* removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Robert Osborne <ozborne132@gmail.com>

* removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com>

* removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>

* removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com>

* Prepare plugin detection for removal of the cmx_3600 adapter (#1488) * add "extract_adapters" to CI triggers * use "otiod" as override example Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Extracted CMX3600 adapter and related sample data and tests (#1487) * Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Extract AAF Adapter from OTIO core and establish separate git repo (#1348) * Remove AAF adapter * Add Note about the AAF adapter being moved Signed-off-by: Mark Reid <mindmark@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove fcp adapter (#1501) * removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove svg adapter (#1502) * removed svg adapter and related test files * updated auto documentation Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove maya sequencer adapter related files (#1520) * Remove maya adapter related files * Update docs Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove fcp x xml adapter related files (#1529) * remove fcp x xml adapter files * update docs Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * remove hls adapter related files (#1535) Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * remove ale adapter related files (#1536) * remove ale adapter related files Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove burnins adapter related files (#1537) * extract burnin files * remove test Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * extract xges adapter files (#1538) * extract xges adapter files Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove the remains of "contrib" * Removed the "contrib" directory tree and all references to the contrib adapters. * Plugin system, setup and auto doc scripts no longer rely on contrib files. * Also removed some entries on other adapters left behind in the adapters.md file. * add README_contrib.md to the manifest Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * fixed `doc-plugins-update` when custom hooks are in environment (#1644) Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * added support for pathlib.Path filepath arguments for adapter IO functions (#1704) Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Removed orphaned FCP XML adapter post-rebase. Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Update README.md to point users to the adapter repos Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> * Updated documentation about adapters to better reflect the current landscape Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Removed contrib plugin manifest from package data Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Removed extract_adapters branch from CI references Signed-off-by: Eric Reinecke <ereinecke@netflix.com> --------- Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> Signed-off-by: Mark Reid <mindmark@gmail.com> Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com> Co-authored-by: Mark Reid <mindmark@gmail.com> Co-authored-by: Rob Osborne <ozborne132@gmail.com> Co-authored-by: Tim Lehr <timlehr@users.noreply.github.com>

* Prepare plugin detection for removal of the cmx_3600 adapter (AcademySoftwareFoundation#1488) * add "extract_adapters" to CI triggers * use "otiod" as override example Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Extracted CMX3600 adapter and related sample data and tests (AcademySoftwareFoundation#1487) * Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Extract AAF Adapter from OTIO core and establish separate git repo (AcademySoftwareFoundation#1348) * Remove AAF adapter * Add Note about the AAF adapter being moved Signed-off-by: Mark Reid <mindmark@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove fcp adapter (AcademySoftwareFoundation#1501) * removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove svg adapter (AcademySoftwareFoundation#1502) * removed svg adapter and related test files * updated auto documentation Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove maya sequencer adapter related files (AcademySoftwareFoundation#1520) * Remove maya adapter related files * Update docs Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove fcp x xml adapter related files (AcademySoftwareFoundation#1529) * remove fcp x xml adapter files * update docs Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * remove hls adapter related files (AcademySoftwareFoundation#1535) Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * remove ale adapter related files (AcademySoftwareFoundation#1536) * remove ale adapter related files Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove burnins adapter related files (AcademySoftwareFoundation#1537) * extract burnin files * remove test Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * extract xges adapter files (AcademySoftwareFoundation#1538) * extract xges adapter files Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Remove the remains of "contrib" * Removed the "contrib" directory tree and all references to the contrib adapters. * Plugin system, setup and auto doc scripts no longer rely on contrib files. * Also removed some entries on other adapters left behind in the adapters.md file. * add README_contrib.md to the manifest Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * fixed `doc-plugins-update` when custom hooks are in environment (AcademySoftwareFoundation#1644) Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * added support for pathlib.Path filepath arguments for adapter IO functions (AcademySoftwareFoundation#1704) Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Removed orphaned FCP XML adapter post-rebase. Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Update README.md to point users to the adapter repos Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> * Updated documentation about adapters to better reflect the current landscape Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Removed contrib plugin manifest from package data Signed-off-by: Eric Reinecke <ereinecke@netflix.com> * Removed extract_adapters branch from CI references Signed-off-by: Eric Reinecke <ereinecke@netflix.com> --------- Signed-off-by: apetrynet <flehnerheener@gmail.com> Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com> Signed-off-by: Eric Reinecke <ereinecke@netflix.com> Signed-off-by: Mark Reid <mindmark@gmail.com> Signed-off-by: rosborne132 <ozborne132@gmail.com> Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com> Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com> Co-authored-by: Mark Reid <mindmark@gmail.com> Co-authored-by: Rob Osborne <ozborne132@gmail.com> Co-authored-by: Tim Lehr <timlehr@users.noreply.github.com> Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>

apetrynet added 30 commits November 28, 2022 19:59

First pass at removing the cmx_3600 adapter

2c3a53c

Signed-off-by: apetrynet <flehnerheener@gmail.com>

removed sample data only used by the cmx_3600 adapter

b190f7c

Signed-off-by: apetrynet <flehnerheener@gmail.com>

First pass at removing the cmx_3600 adapter

7305fbe

Signed-off-by: apetrynet <flehnerheener@gmail.com>

removed sample data only used by the cmx_3600 adapter

e6268a4

Signed-off-by: apetrynet <flehnerheener@gmail.com>

replaced imp with importlib

3bb804a

Signed-off-by: apetrynet <flehnerheener@gmail.com>

print

3d47054

Signed-off-by: apetrynet <flehnerheener@gmail.com>

debugging

8a2be00

Signed-off-by: apetrynet <flehnerheener@gmail.com>

Merge branch 'extract_adapters' of github.com:apetrynet/OpenTimelineI…

07b92ea

…O into extract_adapters

reverted importlib change. Not meant to be a part of this PR

1e9da45

Signed-off-by: apetrynet <flehnerheener@gmail.com>

Moving this change to a separate PR

e641e36

Signed-off-by: apetrynet <flehnerheener@gmail.com>

add "extract_adapters" to CI triggers

c5027a8

Signed-off-by: apetrynet <flehnerheener@gmail.com>

reverted test_plugin_detection.py to look for cmx_3600 as it is chang…

cfc1f42

…ed in a separate PR. Will rebase when merged Signed-off-by: apetrynet <flehnerheener@gmail.com>

otioz test called for an edl we removed. Replaced with an otio file

8648685

Signed-off-by: apetrynet <flehnerheener@gmail.com>

updated variable name to match new test source

61068a2

Signed-off-by: apetrynet <flehnerheener@gmail.com>

converted screening_example.edl to screening_example.otio and used it…

0913d20

… in tests Signed-off-by: apetrynet <flehnerheener@gmail.com>

First pass at removing the cmx_3600 adapter

5cb3bcd

Signed-off-by: apetrynet <flehnerheener@gmail.com>

removed sample data only used by the cmx_3600 adapter

b0c7fa0

Signed-off-by: apetrynet <flehnerheener@gmail.com>

replaced imp with importlib

261b12c

Signed-off-by: apetrynet <flehnerheener@gmail.com>

print

e4c7f93

Signed-off-by: apetrynet <flehnerheener@gmail.com>

debugging

2f31b30

Signed-off-by: apetrynet <flehnerheener@gmail.com>

reverted importlib change. Not meant to be a part of this PR

fc34ac9

Signed-off-by: apetrynet <flehnerheener@gmail.com>

otioz test called for an edl we removed. Replaced with an otio file

4715115

Signed-off-by: apetrynet <flehnerheener@gmail.com>

updated variable name to match new test source

87a6b44

Signed-off-by: apetrynet <flehnerheener@gmail.com>

converted screening_example.edl to screening_example.otio and used it…

3f43360

… in tests Signed-off-by: apetrynet <flehnerheener@gmail.com>

removed other adapter suffixes as they belong to adapters soon to be …

918c30f

…extracted Signed-off-by: apetrynet <flehnerheener@gmail.com>

Merge remote-tracking branch 'origin/extract_adapters' into extract_a…

0fe30a8

…dapters # Conflicts: # tests/test_examples.py

SCREENING_EXAMPLE_PATH is back using the otio version

aba8207

Signed-off-by: apetrynet <flehnerheener@gmail.com>

autogenerated docs for CMX3600 removed

9bc9d52

Signed-off-by: apetrynet <flehnerheener@gmail.com>

removing the fcp adapter and it's files

c9e585e

Signed-off-by: apetrynet <flehnerheener@gmail.com>

replaced premiere_example.xml with premiere_example.otio to pass cons…

0b3849f

…ole tests. Signed-off-by: apetrynet <flehnerheener@gmail.com>

apetrynet added 5 commits December 15, 2022 00:12

Merge branch 'AcademySoftwareFoundation:extract_adapters' into extrac…

d234b73

…t_adapters

removing the fcp adapter and it's files

ccb9c15

Signed-off-by: apetrynet <flehnerheener@gmail.com>

replaced premiere_example.xml with premiere_example.otio to pass cons…

25a6f2c

…ole tests. Signed-off-by: apetrynet <flehnerheener@gmail.com>

Merge remote-tracking branch 'origin/remove_fcp_adapter' into remove_…

983063a

…fcp_adapter

updated autogenerated docs

33ceeb4

Signed-off-by: apetrynet <flehnerheener@gmail.com>

apetrynet changed the base branch from main to extract_adapters December 14, 2022 23:23

updated autogenerated docs to catch the removed aaf adapter

bcf3b90

Signed-off-by: apetrynet <flehnerheener@gmail.com>

removed FIXME comment

012cbc7

Signed-off-by: apetrynet <flehnerheener@gmail.com>

apetrynet merged commit 04e6ab2 into AcademySoftwareFoundation:extract_adapters Dec 15, 2022

apetrynet deleted the remove_fcp_adapter branch October 9, 2025 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove fcp adapter #1501

Remove fcp adapter #1501

Uh oh!

apetrynet commented Dec 14, 2022

Uh oh!

codecov-commenter commented Dec 14, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Remove fcp adapter #1501

Remove fcp adapter #1501

Uh oh!

Conversation

apetrynet commented Dec 14, 2022

Uh oh!

codecov-commenter commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov-commenter commented Dec 14, 2022 •

edited

Loading