Skip to content

Conversation

@jminor
Copy link
Collaborator

@jminor jminor commented Nov 3, 2022

This PR adds a new --relink-by-name option to otiotool which allows you to relink clips to media files in a given folder by matching the clip name to the filename (ignoring file extension).

Also included in this PR are some small improvements to the otiotool usage statement.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1475 (d5732f4) into main (b6fbca2) will increase coverage by 0.08%.
The diff coverage is 79.48%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   78.89%   78.97%   +0.08%     
==========================================
  Files         200      200              
  Lines       21724    21816      +92     
  Branches     4403     4415      +12     
==========================================
+ Hits        17139    17230      +91     
  Misses       2355     2355              
- Partials     2230     2231       +1     
Flag Coverage Δ
py-unittests 78.97% <79.48%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-opentimelineio/opentimelineio/console/otiotool.py 73.31% <68.00%> (-0.45%) ⬇️
tests/test_console.py 95.33% <100.00%> (+0.22%) ⬆️
tests/test_cmx_3600_adapter.py 99.59% <0.00%> (+0.02%) ⬆️
src/opentimelineio/serialization.cpp 47.99% <0.00%> (+0.18%) ⬆️
...opentimelineio/opentimelineio/adapters/cmx_3600.py 85.06% <0.00%> (+0.28%) ⬆️
tests/test_plugin_detection.py 91.46% <0.00%> (+0.67%) ⬆️
...ntimelineio/opentimelineio-bindings/otio_tests.cpp 28.72% <0.00%> (+1.06%) ⬆️
...-opentimelineio/opentimelineio/plugins/manifest.py 91.50% <0.00%> (+4.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fbca2...d5732f4. Read the comment docs.

@jminor
Copy link
Collaborator Author

jminor commented Nov 18, 2022

Test failure resolved. I think this is ready to go.

@jminor jminor merged commit 33e0d1a into AcademySoftwareFoundation:main Nov 23, 2022
@jminor jminor deleted the relink branch November 23, 2022 21:18
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
…#1475)

Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants