Add Python 3.11 to CI matrix #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
force-pushed
the
python311
branch
from
66be756 to
f9d82e6
Compare
Member
Author
|
Well, it looks like we'll need to update the manylinux docker image to 2014. |
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
force-pushed
the
python311
branch
from
41570e7 to
6a202ec
Compare
Member
Author
|
I just pushed a commit to update to manylinux 2014. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
=======================================
Coverage 78.89% 78.89%
=======================================
Files 200 200
Lines 21724 21724
Branches 4403 4403
=======================================
Hits 17140 17140
Misses 2354 2354
Partials 2230 2230
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Collaborator
|
Looking good. Is this work in progress or ready to review? If WIP, maybe convert to Draft? |
Member
Author
|
It is ready to review. |
MichaelPlug
pushed a commit
to MichaelPlug/OpenTimelineIO
that referenced
this pull request
Aug 5, 2023
* Add Python 3.11 to CI matrix * Update manylinux docker images to 2014 Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Signed-off-by: Michele Spina <michelespina96@gmail.com>
Collaborator
|
Fixes #1667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 was release on Oct. 24, 2022. This PR adds 3.11 to the CI matrix so that we can make sure everything is working as expected even if we don't publish wheels yet.
Note that in order to get 3.11 wheels, I had to update the manylinux docker images to use
manylinux2014.manylinux2010was a CentOS 6 based imaged while 2014 is a CentOS 7 based image. Because 2014 uses glibc 2.17, we are fully compatible with the vfx platform years we support. Also, 2014 uses GCC 10 (10.2.1 to be precised).