Import _opentime before actually creating the bindings for _otio #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s allows to import _otio without manually importing _opentime before. Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 199 199
Lines 20522 20523 +1
Branches 2375 2375
=======================================
+ Hits 17674 17675 +1
Misses 2267 2267
Partials 581 581
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
meshula
requested changes
Sep 17, 2022
src/py-opentimelineio/opentimelineio-bindings/otio_bindings.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
deleted the
import_opentime_before_binding_otio
branch
MichaelPlug
pushed a commit
to MichaelPlug/OpenTimelineIO
that referenced
this pull request
Aug 5, 2023
…demySoftwareFoundation#1396) Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that doing
python -c 'import opentimelineio._otio'was not working. It was resulting in an import error:This error doesn't normally happen because we usually go through
opentimelineio/__init__.pywhich imports_opentimebefore importing_otio.After some searching, I found https://pybind11.readthedocs.io/en/stable/advanced/misc.html#partitioning-code-over-multiple-extension-modules which describes some options to fix this. This PR implements the simplest option out there, which is to import
_opentimebefore actually creating the_otiobindings.This should be harmless because it is going to be a no-op when importing OTIO normally (via
import opentimelineio). It will be a no-op in this case bacause Python doesn't re-import a package if imported twice.