Add support for Premiere styled EDLs to the CMX 3600 adapter #1199
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
- Coverage 86.08% 86.07% -0.01%
==========================================
Files 191 191
Lines 19228 19226 -2
Branches 2292 2292
==========================================
- Hits 16552 16549 -3
Misses 2123 2123
- Partials 553 554 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
reinecke
left a comment
reinecke
left a comment
There was a problem hiding this comment.
I think we could merge this and be fine as is, I just had one minor thought. Thanks for the fix!
|
Oops, sorry, one other note - would you mind adding a unittest to check the behavior? |
|
@douglascomet This looks ready to merge, did you have any thoughts about @reinecke's request for a test? |
|
Hi, @douglascomet ! |
douglascomet
force-pushed
the
cmx_3600_premiere_style
branch
from
e684d8c to
a415c43
Compare
…applied and support a null value for the added Premiere style Signed-off-by: Doug Halley <douglascomet@gmail.com>
…ave a spec Signed-off-by: Doug Halley <douglascomet@gmail.com>
Signed-off-by: Doug Halley <douglascomet@gmail.com>
Signed-off-by: Doug Halley <douglascomet@gmail.com>
douglascomet
force-pushed
the
cmx_3600_premiere_style
branch
from
9939090 to
a7cc58c
Compare
|
@apetrynet, thanks to your help we have resolved all the CI issues this PR was having! |
apetrynet
changed the title
apetrynet
changed the title
|
Thank you for your contribution @douglascomet ! |
…SoftwareFoundation#1199) * Converted VALID_EDL_STYLES into a dict to consolidate how a style is applied and support a null value for the added Premiere style * Update style spec and added fallback OTIO comment if style does not have a spec * Added sample edl for avid and premiere Signed-off-by: Doug Halley <douglascomet@gmail.com> Signed-off-by: Michele Spina <michelespina96@gmail.com>
5 participants
Fixes[1178] Premiere style for cmx3600
Summary.
Adds support for Premiere style for cmx3600 to limit the auto added comments that are added per clip when writing out an EDL.
Tests.
No new tests were added but the below is failing when running
make testyet nearest_valid_timecode_rate seem like it should be available from the C++ class definition:Additionally, when I attempt to run
make lintI get this error even thoughpydocstyleis in my venv: