Skip to content

Kdenlive adapter: process recent project format #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

vpinon
Copy link
Contributor

@vpinon vpinon commented Jan 13, 2022

Fixes #1159
Fixes #1160
Don't rely anymore on old "global_feed" attribute to identify main tractor, but check last tractor in xml is the top one.

@vpinon vpinon force-pushed the kdenlive_globalfeed branch from 63f9faf to 19b8dd2 Compare January 13, 2022 22:32
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #1191 (19b8dd2) into main (1e44ca2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
- Coverage   86.08%   86.05%   -0.03%     
==========================================
  Files         191      191              
  Lines       19228    19234       +6     
  Branches     2292     2295       +3     
==========================================
  Hits        16552    16552              
- Misses       2123     2128       +5     
- Partials      553      554       +1     
Flag Coverage Δ
unittests 86.05% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrib/opentimelineio_contrib/adapters/kdenlive.py 80.37% <0.00%> (-1.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e44ca2...19b8dd2. Read the comment docs.

@jminor jminor merged commit 2035d38 into AcademySoftwareFoundation:main Feb 7, 2022
@jminor
Copy link
Collaborator

jminor commented Feb 7, 2022

Thanks @vpinon and @codingcatgirl!

jminor pushed a commit that referenced this pull request Feb 11, 2022
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kdenlive adapter no longer working
5 participants