ci: Some minor llvm dependency improvements#2090
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
ci: Some minor llvm dependency improvements#2090lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
While debugging some CI failures on Windows, I went down some wrong roads that turned out not to be related to the actual problem... but nevertheless are improvements I wish to keep. Here they are: * Attempt to use the install-llvm-action from Windows wasn't able to work (among other reasons) because we weren't passing along the llvm_action_ver variable. * For reasons I never quite understood, the llvm install action works a lot better on Windows if done before the "build setup" step. So I just moved that action earlier in the sequence. * Some status messages about how we are installing LLVM. * A correction in how we detect and print the pkg_ROOT environment variable in the log generated by handle_package_notfound. * Allow LLVM_PATH (set by that action) to be a proper hint for FindLLVM.cmake. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging some CI failures on Windows, I went down some wrong roads that turned out not to be related to the actual problem... but nevertheless are improvements I wish to keep. Here they are:
Attempt to use the install-llvm-action from Windows wasn't able to work (among other reasons) because we weren't passing along the llvm_action_ver variable.
For reasons I never quite understood, the llvm install action works a lot better on Windows if done before the "build setup" step. So I just moved that action earlier in the sequence.
Some status messages about how we are installing LLVM.
A correction in how we detect and print the pkg_ROOT environment variable in the log generated by handle_package_notfound.
Allow LLVM_PATH (set by that action) to be a proper hint for FindLLVM.cmake.