build(deps): Adjust to OIIO change to IC/TS API #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the OIIO side, there's a PR in review that changes the ImageCache and TextureSystem APIs to return shared_ptr instead of raw. (AcademySoftwareFoundation/OpenImageIO#4377) This is destined for the upcoming OIIO 3.0 release. This patch on the OSL side ensures that we build cleanly against both OIIO 2.x and 3.0. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
that referenced
this pull request
Aug 18, 2024
Didn't catch them all in #1848 -- missed the BatchedRendererServices side. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
…ation#1848) On the OIIO side, there's a PR in review that changes the ImageCache and TextureSystem APIs to return shared_ptr instead of raw. (AcademySoftwareFoundation/OpenImageIO#4377) This is destined for the upcoming OIIO 3.0 release. This patch on the OSL side ensures that we build cleanly against both OIIO 2.x and 3.0. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
Didn't catch them all in AcademySoftwareFoundation#1848 -- missed the BatchedRendererServices side. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
…ation#1848) On the OIIO side, there's a PR in review that changes the ImageCache and TextureSystem APIs to return shared_ptr instead of raw. (AcademySoftwareFoundation/OpenImageIO#4377) This is destined for the upcoming OIIO 3.0 release. This patch on the OSL side ensures that we build cleanly against both OIIO 2.x and 3.0. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
Didn't catch them all in AcademySoftwareFoundation#1848 -- missed the BatchedRendererServices side. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
…ation#1848) On the OIIO side, there's a PR in review that changes the ImageCache and TextureSystem APIs to return shared_ptr instead of raw. (AcademySoftwareFoundation/OpenImageIO#4377) This is destined for the upcoming OIIO 3.0 release. This patch on the OSL side ensures that we build cleanly against both OIIO 2.x and 3.0. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
Didn't catch them all in AcademySoftwareFoundation#1848 -- missed the BatchedRendererServices side. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the OIIO side, there's a PR in review that changes the ImageCache and TextureSystem APIs to return shared_ptr instead of raw. (AcademySoftwareFoundation/OpenImageIO#4377) This is destined for the upcoming OIIO 3.0 release.
This patch on the OSL side ensures that we build cleanly against both OIIO 2.x and 3.0 after that patch is merged.