Skip to content

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Dec 27, 2023

Bump the "bleeding edge" test to LLVM 17, the "stable latest releases" test to 16.

Bump the "bleeding edge" test to LLVM 17, the "stable latest releases"
test to 16.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented Jan 4, 2024

Does this seem ok?

@AlexMWells
Copy link
Contributor

So which clang versions will CI be exercising now?

@lgritz
Copy link
Collaborator Author

lgritz commented Jan 4, 2024

Clang or LLVM?

With this test, I believe our CI will test against llvm (for JIT) with every major version from 9 to 17, inclusive. (That actually feels like unnecessarily many, maybe it's time to raise the minimum for future OSL 1.14+ releases?)

But our CI only builds with a few versions of clang: 9, 13, and 14 (on Linux), and 15 (on Mac). Most of our build matrix uses gcc, plus the icc & icx tests. It would be unwieldy to expand the CI tests to make every combination test against every compiler, so we kind of sample. Historically, we have rarely or never found much sensitivity to building against one or another version of clang, as long as they both support the same level of C++ standard.

The one exception is that sometimes newer versions monotonically add new warnings, so we should always be doing one build with the very latest clang to make sure we compile cleanly with no warnings. I'll amend this PR to make sure one build uses the latest clang 17 to ensure we have full coverage there.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented Jan 4, 2024

Amended: Test clang 17 compilation with MacOS-13 build

@lgritz lgritz merged commit 378f056 into AcademySoftwareFoundation:main Jan 10, 2024
@lgritz lgritz deleted the lg-llvm17ci branch January 10, 2024 04:27
lgritz added a commit to lgritz/OpenShadingLanguage that referenced this pull request Jan 10, 2024
Bump the "bleeding edge" test to LLVM 17, the "stable latest releases"
test to 16.

Cover clang 17 compilation with MacOS-13 build

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants