specify full path to the grep utility#1093
Open
mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
specify full path to the grep utility#1093mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
mcoliver wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
some people have grep aliased to something else like rg which uses -E differently. Specifying the full path to the grep bin ensures we are using the right utility. Signed-off-by: Michael Oliver <mcoliver@gmail.com>
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some people have grep aliased to something else like rg which uses -E differently. Specifying the full path to the grep bin ensures we are using the right utility.
Linked issues
Fixes #1092
Summarize your change.
Full pathname to grep utility
Describe the reason for the change.
It's great that if the build fails it attempts to grep for things like errors. The issue is that sometime people (like me) have grep aliased to something like ripgrep or silver searcher (ag) which sometimes use flags differently. For example -E is different in gnu grep and ripgrep. Referencing the tool with the full pathname to ensure we are using /usr/bin/grep would be more deterministic.
Describe what you have tested and on which operating system.
macos
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.