Open
Conversation
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
XCode26 was refusing to build Qt 6.5.3 and 6.8.3 because it lacks AGL. AGL is no longer used and newer versions of Qt have patched. This is a backport to patch 6.5.3 and 6.8.3. For reference: https://qt-project.atlassian.net/browse/QTBUG-137687 qt/qtbase@cdb33c3 Homebrew/homebrew-core@9ef0937 Signed-off-by: Michael Oliver <mcoliver@gmail.com>
updated cmake/dependencies/python3.cmake to use the IMPORTED_NO_SYSTEM property for the Python::Python target. This ensures that the Python include paths are treated as regular include paths (-I) rather than system include paths (-isystem), which resolves search order issues on newer Xcode versions. Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
cmake-format -i CMakeLists.txt cmake/**/*.cmake Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Comment on lines
531
to
534
| SET_TARGET_PROPERTIES( | ||
| Python::Python | ||
| PROPERTIES IMPORTED_NO_SYSTEM ON | ||
| ) |
Contributor
There was a problem hiding this comment.
What issue did you encounter that needed this change?
Also, IMPORTED_NO_SYSTEM is deprecated since CMake 3.25. Could you use the alternative?
https://cmake.org/cmake/help/v3.31/prop_tgt/IMPORTED_NO_SYSTEM.html
Contributor
Author
There was a problem hiding this comment.
I should have saved the full message. Without that command I was getting a message along the lines ofUnable to find Python.h. Nice find on the deprecation. We can use SYSTEM FALSE instead. I have pushed a new commit.
See this link for more details https://cmake.org/cmake/help/v3.31/prop_tgt/IMPORTED_NO_SYSTEM.html Signed-off-by: Michael Oliver <mcoliver@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ 1090: Build with Xcode26 ]
Linked issues
Fixes #1090
Summarize your change.
Backported a patch to Qt 6.5.3 and 6.8.3 which are the community versions available and do not have the patch in commercial versions
Describe the reason for the change.
Want to build with Xcode26. Was annoying to constantly have to switch with xcode-select. Additionally xcode26 should bring some compiler optimizations that may improve performance.
Describe what you have tested and on which operating system.
macos26.2 with Xcode26.2. RV CY2025