transmission_scatter sets volume albedo directly - #286
Merged
AdrienHerubel merged 4 commits intoJan 20, 2026
Merged
Conversation
Contributor
Author
|
It would be helpful if the reviewers can verify that the changes to the MaterialX graph are correct. |
Contributor
|
As discussed in the meeting, we are now considering this look breaking change for 1.2. @peterkutz can you please formally review ? |
peterkutz
approved these changes
Jan 17, 2026
peterkutz
left a comment
peterkutz
left a comment
Contributor
There was a problem hiding this comment.
Reviewed and approved! I've been looking forward to this simplification. Thanks for officially updating the spec @portsmouth .
I have not carefully reviewed the .mtlx changes because I'm not particularly familiar with MaterialX syntax.
AdrienHerubel
self-requested a review
January 20, 2026 18:04
AdrienHerubel
approved these changes
Jan 20, 2026
AdrienHerubel
left a comment
AdrienHerubel
left a comment
Contributor
There was a problem hiding this comment.
There is a consensus that this PR should be merged and has been reviewed and approved.
AdrienHerubel
merged commit Jan 20, 2026
0262ba0
into
AcademySoftwareFoundation:dev_1.2
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes as below. See #275 for the difference in appearance, which is clearly more intuitive.
This gets rid of the previous rather clumsy adjustment of the absorption and extinction to accommodate the arbitrarily high scattering coefficient. The MaterialX graph is correspondingly simplified.
As discussed in #275, this is now also more consistent with the existing parametrization since the$[0,1]$ range of the components is correct (whereas before the $[0,1]$ range didn't make sense).
transmission_scattercolor is an albedo so the