clamp all inputs according to the parameter reference (section 4 of the spec) (#276) - #277
Merged
AdrienHerubel merged 2 commits intoSep 30, 2025
Conversation
AdrienHerubel
self-requested a review
September 30, 2025 15:21
AdrienHerubel
approved these changes
Sep 30, 2025
AdrienHerubel
left a comment
AdrienHerubel
left a comment
Contributor
There was a problem hiding this comment.
As discussed in the meetings and on Slack, there is a consensus that clamping in the nodegraph ensures consistency across implementations and discourages users to explicitly clamp inputs of the graphs.
AdrienHerubel
merged commit Sep 30, 2025
08031ea
into
AcademySoftwareFoundation:dev_1.2
1 check passed
Contributor
|
I think the specification should reflect this decision; was it amended separately? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure defined and portable behavior across renderers.
Note this supersedes/replaces #270 #271 #272 and #273